chore: remove default inference params

janhq · Jun 25, 2024 · 8c86e2a · 8c86e2a
1 parent dfb2254
commit 8c86e2a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/cortex-js/src/infrastructure/commanders/usecases/chat.cli.usecases.ts b/cortex-js/src/infrastructure/commanders/usecases/chat.cli.usecases.ts
@@ -63,6 +63,8 @@ export class ChatCliUsecases {
     rl.on('line', sendCompletionMessage.bind(this));
 
     async function sendCompletionMessage(userInput: string) {
+      if (!userInput || userInput.trim() === '') return;
+
       if (userInput.trim() === this.exitClause) {
         rl.close();
         return;
@@ -98,11 +100,7 @@ export class ChatCliUsecases {
         model: modelId,
         stream: true,
         max_tokens: 4098,
-        stop: [],
         frequency_penalty: 0.7,
-        presence_penalty: 0.7,
-        temperature: 0.7,
-        top_p: 0.7,
 
         // Override with model settings
         ...parser.parseModelInferenceParams(model),

diff --git a/cortex-js/src/infrastructure/constants/benchmark.ts b/cortex-js/src/infrastructure/constants/benchmark.ts
@@ -18,7 +18,6 @@ export const defaultBenchmarkConfiguration: BenchmarkConfig = {
       model: 'tinyllama',
       stream: true,
       max_tokens: 2048,
-      stop: [],
       frequency_penalty: 0,
       presence_penalty: 0,
       temperature: 0.7,