fix: create assistant (#1773)

* fix: create assistant * fix ci
janhq · Dec 6, 2024 · 4700f8d · 4700f8d
1 parent 97e5636
commit 4700f8d
Show file tree

Hide file tree

Showing 10 changed files with 38 additions and 18 deletions.
diff --git a/engine/common/thread.h b/engine/common/thread.h
@@ -156,6 +156,19 @@ struct Thread : JsonSerializable {
       }
       json["metadata"] = metadata_json;
 
+      if (assistants.has_value()) {
+        Json::Value assistants_json(Json::arrayValue);
+        for (auto& assistant : assistants.value()) {
+          auto assistant_result = assistant.ToJson();
+          if (assistant_result.has_error()) {
+            return cpp::fail("Failed to serialize assistant: " +
+                             assistant_result.error());
+          }
+          assistants_json.append(assistant_result.value());
+        }
+        json["assistants"] = assistants_json;
+      }
+
       return json;
     } catch (const std::exception& e) {
       return cpp::fail(std::string("ToJson failed: ") + e.what());

diff --git a/engine/controllers/hardware.cc b/engine/controllers/hardware.cc
@@ -1,8 +1,6 @@
 #include "hardware.h"
-#include "common/hardware_config.h"
 #include "utils/cortex_utils.h"
-#include "utils/file_manager_utils.h"
-#include "utils/scope_exit.h"
+#include "utils/logging_utils.h"
 
 void Hardware::GetHardwareInfo(
     const HttpRequestPtr& req,
@@ -73,4 +71,4 @@ void Hardware::Activate(
   callback(resp);
   app().quit();
 #endif
-}
+}
diff --git a/engine/controllers/threads.cc b/engine/controllers/threads.cc
@@ -25,6 +25,7 @@ void Threads::ListThreads(
   Json::Value msg_arr(Json::arrayValue);
   for (auto& msg : res.value()) {
     if (auto it = msg.ToJson(); it.has_value()) {
+      it->removeMember("assistants");
       msg_arr.append(it.value());
     } else {
       CTL_WRN("Failed to convert message to json: " + it.error());
@@ -114,8 +115,9 @@ void Threads::RetrieveThread(
       resp->setStatusCode(k400BadRequest);
       callback(resp);
     } else {
+      thread_to_json->removeMember("assistants");
       auto resp =
-          cortex_utils::CreateCortexHttpJsonResponse(res->ToJson().value());
+          cortex_utils::CreateCortexHttpJsonResponse(thread_to_json.value());
       resp->setStatusCode(k200OK);
       callback(resp);
     }

diff --git a/engine/database/hardware.cc b/engine/database/hardware.cc
@@ -1,14 +1,13 @@
 #include "hardware.h"
 #include "database.h"
+#include "utils/logging_utils.h"
 #include "utils/scope_exit.h"
 
 namespace cortex::db {
 
-Hardwares::Hardwares() : db_(cortex::db::Database::GetInstance().db()) {
-}
+Hardwares::Hardwares() : db_(cortex::db::Database::GetInstance().db()) {}
 
-Hardwares::Hardwares(SQLite::Database& db) : db_(db) {
-}
+Hardwares::Hardwares(SQLite::Database& db) : db_(db) {}
 
 Hardwares::~Hardwares() {}
 
@@ -94,4 +93,4 @@ cpp::result<bool, std::string> Hardwares::DeleteHardwareEntry(
     return cpp::fail(e.what());
   }
 }
-}  // namespace cortex::db
+}  // namespace cortex::db
diff --git a/engine/database/models.cc b/engine/database/models.cc
@@ -2,6 +2,7 @@
 #include <algorithm>
 #include <sstream>
 #include "database.h"
+#include "utils/logging_utils.h"
 #include "utils/result.hpp"
 #include "utils/scope_exit.h"
 
@@ -339,4 +340,4 @@ bool Models::HasModel(const std::string& identifier) const {
   }
 }
 
-}  // namespace cortex::db
+}  // namespace cortex::db
diff --git a/engine/test/components/test_cortex_config.cc b/engine/test/components/test_cortex_config.cc
@@ -1,3 +1,7 @@
+#include <yaml-cpp/node/node.h>
+#include <yaml-cpp/node/parse.h>
+#include <filesystem>
+#include <fstream>
 #include "gtest/gtest.h"
 #include "utils/config_yaml_utils.h"
 

diff --git a/engine/test/components/test_cortex_upd_cmd.cc b/engine/test/components/test_cortex_upd_cmd.cc
@@ -1,4 +1,5 @@
-#include "cli/commands/cortex_upd_cmd.h"
+#include <filesystem>
+#include <fstream>
 #include "gtest/gtest.h"
 
 namespace {

diff --git a/engine/test/components/test_file_manager_config_yaml_utils.cc b/engine/test/components/test_file_manager_config_yaml_utils.cc
@@ -1,6 +1,7 @@
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 #include <filesystem>
+#include <fstream>
 #include "utils/config_yaml_utils.h"
 #include "utils/file_manager_utils.h"
 

diff --git a/engine/utils/config_yaml_utils.cc b/engine/utils/config_yaml_utils.cc
@@ -1,4 +1,9 @@
 #include "config_yaml_utils.h"
+#include <filesystem>
+#include <fstream>
+#include <iostream>
+#include "utils/logging_utils.h"
+#include "yaml-cpp/yaml.h"
 
 namespace config_yaml_utils {
 cpp::result<void, std::string> CortexConfigMgr::DumpYamlConfig(
@@ -174,4 +179,4 @@ CortexConfig CortexConfigMgr::FromYaml(const std::string& path,
   }
 }
 
-}  // namespace config_yaml_utils
+}  // namespace config_yaml_utils
diff --git a/engine/utils/config_yaml_utils.h b/engine/utils/config_yaml_utils.h
@@ -1,13 +1,9 @@
 #pragma once
 
-#include <filesystem>
-#include <fstream>
-#include <iostream>
 #include <mutex>
 #include <string>
-#include "utils/logging_utils.h"
+#include <vector>
 #include "utils/result.hpp"
-#include "yaml-cpp/yaml.h"
 
 namespace config_yaml_utils {