fix: should not return failed code on model already loaded (#913)

janhq · Jul 25, 2024 · 2004d9e · 2004d9e
1 parent 5caef68
commit 2004d9e
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/cortex-js/src/usecases/models/models.usecases.ts b/cortex-js/src/usecases/models/models.usecases.ts
@@ -197,6 +197,11 @@ export class ModelsUsecases {
 
     return engine
       .loadModel(model, loadModelSettings)
+      .catch((e) => {
+        // Skip model already loaded error
+        if (e.code === AxiosError.ERR_BAD_REQUEST) return;
+        else throw e;
+      })
       .then(() => {
         this.activeModelStatuses[modelId] = {
           model: modelId,
@@ -226,13 +231,6 @@ export class ModelsUsecases {
           metadata: {},
         };
         this.eventEmitter.emit('model.event', modelEvent);
-        if (e.code === AxiosError.ERR_BAD_REQUEST) {
-          loadingModelSpinner.succeed('Model loaded');
-          return {
-            message: 'Model already loaded',
-            modelId,
-          };
-        }
         loadingModelSpinner.fail('Model loading failed');
         await this.telemetryUseCases.createCrashReport(
           e,