Fix attributes being dropped from packed module expressions and patterns #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following program, attributes
[@attr2]
and[@attr3]
are both dropped by ocamlformat silently:In the standard parser, expressions and patterns like
(module M : S)
are parsed as constraints wrapping an inner expression / pattern, while in the extended parser, the package typeS
is part of the same node as the module expression / pattern. In the parsing logic for this, the attributes parsed for the package type are just dropped.In the second commit, we add the attributes to the package type, and handle it as necessary in all code.