Skip to content

Commit

Permalink
Revert "Disable dlfilter by default"
Browse files Browse the repository at this point in the history
This reverts commit 923eaef.

Closes #260
  • Loading branch information
Xyene committed Nov 16, 2022
1 parent 662f689 commit 9fdee3b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions core/env_vars.ml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,8 @@ let debug = Option.is_some (Unix.getenv "MAGIC_TRACE_DEBUG")
features of magic-trace. *)
let experimental = Option.is_some (Unix.getenv "MAGIC_TRACE_EXPERIMENTAL")

(* magic-trace's dlfilter integration is busted right now, see #246. Also:
When tracing the kernel on certain systems, perf only has root access when
(* When tracing the kernel on certain systems, perf only has root access when
being run with a specific set of flags. Since this does not include
[--dlfilter], this environment variable allows the user to forcibly disable
filtering. *)
let no_dlfilter = Option.is_none (Unix.getenv "MAGIC_TRACE_ENABLE_DLFILTER")
let no_dlfilter = Option.is_some (Unix.getenv "MAGIC_TRACE_NO_DLFILTER")

0 comments on commit 9fdee3b

Please sign in to comment.