-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make about dialog show up as fullscreen on iOS #3344
Conversation
62b64fa
to
b57a478
Compare
e4885e4
to
b5298af
Compare
b5298af
to
16af636
Compare
Not sure if you can test this. But please review. |
@ann0see could you explain what the problem behaviour without this fix is? I have just run an old Jamulus I have on my iPad (3.8.2beta1dev-75e4ad0c), and the About and Connect dialogs already show up as full screen with the OK or Connect buttons visible. Running iOS 16.7.10. I can't remember how I got the above version of Jamulus onto my iPad. The icon is just a rounded white square with the word Jamulus in the middle. |
Or is the problem just on an iPhone instead? (I don't have one) |
This is a version from the AppStore and not official in any way. This issue only shows up on Qt6 based iOS builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue only shows up on Qt6 based iOS builds.
OK fair enough. It looks sensible, so happy to approve.
16af636
to
dfa91ba
Compare
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
dfa91ba
to
d8912aa
Compare
@pljones coumd you please also have a look at this? |
Short description of changes
Fixes an UI overflow bug for the about dialog on iOS.
Related to: #3343
Now - with some potential device rotations the about dialog can be exited on Qt6:
CHANGELOG: SKIP
Context: Fixes an issue?
Related to: #3343
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Nothing
Checklist