Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make about dialog show up as fullscreen on iOS #3344

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Aug 7, 2024

Short description of changes
Fixes an UI overflow bug for the about dialog on iOS.

Related to: #3343
Now - with some potential device rotations the about dialog can be exited on Qt6:
About dialog iOS

CHANGELOG: SKIP

Context: Fixes an issue?

Related to: #3343

Does this change need documentation? What needs to be documented and how?

No
Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see force-pushed the iOS/fixAboutDlgOverflow branch from 62b64fa to b57a478 Compare August 7, 2024 20:53
@ann0see ann0see changed the title Make about dialog show up as full screen on iOS Make about dialog show up as fullscreen on iOS Aug 7, 2024
@ann0see ann0see added iOS iOS runtime issue Mobile UI Issues with the UI on mobile platforms labels Aug 7, 2024
@ann0see ann0see force-pushed the iOS/fixAboutDlgOverflow branch 2 times, most recently from e4885e4 to b5298af Compare August 24, 2024 18:02
@pljones pljones added this to the Release 3.12.0 milestone Sep 18, 2024
@ann0see ann0see force-pushed the iOS/fixAboutDlgOverflow branch from b5298af to 16af636 Compare September 22, 2024 15:53
@ann0see ann0see requested review from softins and gilgongo September 24, 2024 21:28
@ann0see
Copy link
Member Author

ann0see commented Sep 24, 2024

Not sure if you can test this. But please review.

@softins
Copy link
Member

softins commented Sep 30, 2024

@ann0see could you explain what the problem behaviour without this fix is? I have just run an old Jamulus I have on my iPad (3.8.2beta1dev-75e4ad0c), and the About and Connect dialogs already show up as full screen with the OK or Connect buttons visible. Running iOS 16.7.10.

I can't remember how I got the above version of Jamulus onto my iPad. The icon is just a rounded white square with the word Jamulus in the middle.

@softins
Copy link
Member

softins commented Sep 30, 2024

Or is the problem just on an iPhone instead? (I don't have one)

@ann0see
Copy link
Member Author

ann0see commented Sep 30, 2024

The icon is just a rounded white square with the word Jamulus in the middle.

This is a version from the AppStore and not official in any way.

This issue only shows up on Qt6 based iOS builds.

Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue only shows up on Qt6 based iOS builds.

OK fair enough. It looks sensible, so happy to approve.

@ann0see ann0see requested a review from pljones October 2, 2024 06:23
src/util.cpp Outdated Show resolved Hide resolved
@ann0see ann0see force-pushed the iOS/fixAboutDlgOverflow branch from 16af636 to dfa91ba Compare October 2, 2024 19:09
@ann0see ann0see requested a review from pljones October 2, 2024 19:09
Fixes an overflow bug for the about dialog on iOS.

Related to: jamulussoftware#3343
@ann0see ann0see force-pushed the iOS/fixAboutDlgOverflow branch from dfa91ba to d8912aa Compare October 2, 2024 20:05
@ann0see ann0see requested review from pljones and removed request for pljones October 3, 2024 18:25
@ann0see
Copy link
Member Author

ann0see commented Oct 4, 2024

@pljones coumd you please also have a look at this?

@pljones
Copy link
Collaborator

pljones commented Oct 4, 2024

Looks okay, too.
AboutDialogFullScreen
(Landscape only when I'm in Jamulus, moto g(9) power, Android 11)

@ann0see ann0see merged commit 7258a55 into jamulussoftware:main Oct 4, 2024
15 checks passed
@ann0see ann0see deleted the iOS/fixAboutDlgOverflow branch October 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS runtime issue Mobile UI Issues with the UI on mobile platforms
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants