Update Mac Legacy from Qt 5.9.9 to 5.15.2 #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softins
force-pushed
the
mac-legacy-update
branch
2 times, most recently
from
9d28a8f to
cdd6697
Compare
softins
changed the title
softins
force-pushed
the
mac-legacy-update
branch
2 times, most recently
from
86acc45 to
dfbfd75
Compare
softins
force-pushed
the
mac-legacy-update
branch
from
dfbfd75 to
9258ad2
Compare
|
Reverted to using Qt 5.15.2, as per #3234 (comment) |
softins
changed the title
softins
force-pushed
the
mac-legacy-update
branch
from
9258ad2 to
96abf40
Compare
|
I would like to progress this now, because I plan to submit a working PR to replace #2393, and that will be dependent on this one having been merged. |
ann0see
approved these changes
Jun 7, 2024
|
We no longer officially link legacy directly on the website anyway as we didn't test it for the last release. So people know it's encouraged not to use it. |
pljones
approved these changes
Jun 7, 2024
|
Great, I'll do a final smoke test of the artifact and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Updates the CI build process and makefiles for Mac Legacy to use Qt 5.15.2 instead of 5.9.9. This allows other things also to be improved separately, as described in #3234
CHANGELOG: Build: Update Mac Legacy build to use Qt 5.15.2, now compatible with MacOS 10.13 (High Sierra) or newer.
Context: Fixes an issue?
Fixes #3234
Does this change need documentation? What needs to be documented and how?
We would need to document in the release notes and any download page that the minimum supported version of MacOS for the Legacy build would be 10.13 (High Sierra)
Status of this Pull Request
Working, but awaiting agreement on using Qt 5.15.2.
What is missing until this pull request can be merged?
Just agreement on using Qt 5.15.2
Checklist