Replace deprecated Q_OS_MACX with Q_OS_MACOS #3227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR replaces all instances of
Q_OS_MACX
withQ_OS_MACOS
CHANGELOG: Build: Replace deprecated Q_OS_MACX with Q_OS_MACOS (Jamulus now requires building with Qt >= 5.7.1)
Context: Fixes an issue?
The
#define
ofQ_OS_MACOS
was introduced in Qt 5.7.1, to replaceQ_OS_MACX
. The latter was still defined for backward-compatibility. Starting with Qt 6.5.2, usingQ_OS_MACX
produces a deprecation warning, for example:A similar change was made in Qt itself at https://codereview.qt-project.org/c/qt/qtbase/+/307095/2
Does this change need documentation? What needs to be documented and how?
Probably not.
Status of this Pull Request
Ready to merge,
What is missing until this pull request can be merged?
Just review
Checklist