Test for Ubuntu and Ubuntu version

[houbsta]

Short description of changes

CHANGELOG: Build: Ensure apt version >=2.4 to prove that the system is Debian based (using apt and dpkg) and can validate the repo

Context: Fixes an issue?

Fixes: #3198

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Basic proof of concept for setup-repo.sh

What is missing until this pull request can be merged?

Has been fully tested on Ubuntu 20.04, 22.04 and MacOS 13.6.

Would require testing on a couple of Debian boxes.

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[houbsta]

I have code to also test for the presence of apt, and to get the version number. Which version is the minimum you consider to be required for the repository to work?

On Ubuntu 20.04 the typical apt version is 2.0.9
On Ubuntu 22.04 the apt version is 2.4.11

I could test for apt >= 2.4.x since there are no 2.1.x - 2.3.x branches.

[ann0see]

Some more comments on more extensive error messages.

CC: @gilgongo

[ann0see]

I could test for apt >= 2.4.x since there are no 2.1.x - 2.3.x branches.

This might hold true for Ubuntu but might not for some other distribution.
I think the broken versions were mentioned in the issue.

https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1950095

[ann0see]

Thanks. Tested on Debian Stable and it seems good.

[ann0see]

Also check the code style check.

[ann0see]

Sorry for being picky.

[houbsta]

No need to apologise. It's nice to get it as clear as possible

[houbsta]

I'm embarrassed about how many commits were necessary for a relatively simple change. If the new format (which I believe I already had, but there you go, maybe one indent wrong, who knows) doesn't validate then I'll just abandon this. It's not worth everyone's time for such a simple change on a script that worked and was tested many commits ago... to fail for minor indentation.
This is a bash script, not main code for the project.

[ann0see]

Thanks for your comment. I'll take care of the styling.
I think the styling CI must be improved then...

[ann0see]

SRY. But it seems to be ok now. I think you can run the beautifier on your device.
Anyways.
It's ok now, I think.

[ann0see]

Seems good like that. Needs further testing by somebody else too before merging.

[houbsta]

I downloaded and ran shfmt on the code and locally it tested OK. I even ran the code through it and pasted that, but I don't have a reference to the coding style. Tried tab (shfmt file.sh > newfile.sh and shfmt -i 4 ...), tried 4 spaces indents (as per instructions on coding found on here).

However I'm pasting into the web interface, maybe that's what caused it. In any case thanks for fixing the styling; it seems I should have got a whole git setup going from the command line but I think I have to update my auth credentials and could do this easily just using the web editor. I was wrong!

[ann0see]

I'm also not sure about the reference for shfmt unfortunately. I thought it uses the default, but maybe not. Probably worth more investigation.

[ann0see]

Todo:
Review and testing from second maindev.

[ann0see]

@pljones @gilgongo Could someone please have a look at this?
Before it's merged we should squash it.

[gilgongo]

@pljones @gilgongo Could someone please have a look at this? Before it's merged we should squash it.

Works for me on Ubuntu 22.04 apt 2.4.11. Downgraded to 2.4.5 and still works. How do I test it with 2.0.x branch?

[houbsta]

Ubuntu 20.04 should fail

[gilgongo]

Ubuntu 20.04 should fail

OK that fails:

Your apt version is incompatible. You may not be able install this repository.
See: https://github.com/orgs/jamulussoftware/discussions/3180
Also of interest: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1950095
Please update your OS or use the .deb package from the Website to manually install Jamulus.
Do you wish to attempt to install the repository anyway?
(not recommended, as you might need to fix your apt configuration)
1) Yes
2) No

One thing that occurs to me is that "Your apt version is incompatible." might imply that Jamulus itself won't run. Should the word order be switched to make it clear that it's just the repo we're talking about? So perhaps:

This repository is not compatible with your apt version.
You can install Jamulus manually using the .deb package from
https://github.com/jamulussoftware/jamulus/releases or update your OS.
For more information see: https://github.com/orgs/jamulussoftware/discussions/3180
Also of interest: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1950095

Sorry, I wasn't sure what the exact context of the wording was until now.

[houbsta]

Ubuntu 20.04 should fail

OK that fails:

Your apt version is incompatible. You may not be able install this repository.
See: https://github.com/orgs/jamulussoftware/discussions/3180
Also of interest: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1950095
Please update your OS or use the .deb package from the Website to manually install Jamulus.
Do you wish to attempt to install the repository anyway?
(not recommended, as you might need to fix your apt configuration)
1) Yes
2) No

One thing that occurs to me is that "Your apt version is incompatible." might imply that Jamulus itself won't run. Should the word order be switched to make it clear that it's just the repo we're talking about? So perhaps:

This repository is not compatible with your apt version.
You can install Jamulus manually using the .deb package from
https://github.com/jamulussoftware/jamulus/releases or update your OS.
For more information see: https://github.com/orgs/jamulussoftware/discussions/3180
Also of interest: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1950095

Sorry, I wasn't sure what the exact context of the wording was until now.

I have made the updates as per your suggestion, good idea.

[houbsta]

I literally just copy/pasted in the web editor without changing anything, then saved, keeping all spacing identical (in theory). Clearly the web editor breaks coding style no matter what I do. What a nightmare.

[ann0see]

Do you see the CI output? It tells me that the if has wrong spacing. So click the Checks tab and the code style check. That's how I found the problems

[ann0see]

All good. Merged and thanks for the patience