Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable #3184

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Remove unused variable #3184

merged 1 commit into from
Oct 5, 2023

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented Oct 2, 2023

Remove unused variable

CHANGELOG: SKIP

@pljones
Copy link
Collaborator Author

pljones commented Oct 2, 2023

(Yes, it can be deleted from the method signature for CClientSettings.)

@softins
Copy link
Member

softins commented Oct 3, 2023

Why isn't the , const QList<QString>& also deleted?

@pljones
Copy link
Collaborator Author

pljones commented Oct 3, 2023

Why isn't the , const QList<QString>& also deleted?

Because it's in the base class method signature.

@pljones pljones merged commit 5fdd707 into jamulussoftware:main Oct 5, 2023
11 checks passed
@pljones pljones deleted the patch/2850-remove-cleanuplegacyfadersettings branch October 5, 2023 17:41
@pljones pljones added the refactoring Non-behavioural changes, Code cleanup label Nov 24, 2024
@pljones pljones added this to the Release 3.11.0 milestone Dec 7, 2024
@pljones pljones self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann0see ann0see ann0see approved these changes

@softins softins softins approved these changes

Assignees

@pljones pljones

Labels
refactoring Non-behavioural changes, Code cleanup
Projects
Tracking
Status: Done
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pljones @softins @ann0see