Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile-first UI implementation with Semantic UI #20

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Mobile-first UI implementation with Semantic UI #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c9ed140
Get basic template working so I can begin developing
aelishRollo Jun 6, 2024
5351b3f
Prepare to integrate Semantic UI library
aelishRollo Jun 6, 2024
2281033
Create static layout
aelishRollo Jun 6, 2024
559a12f
fix ci linting
mickmister Jun 7, 2024
b351255
lint
mickmister Jun 10, 2024
ca710fe
undo file deletions
mickmister Jun 29, 2024
c21b959
remove unused css files
mickmister Jun 29, 2024
d2bdbf3
rename Foo to SectionView
mickmister Jun 29, 2024
82cbee9
Implement <ProjectView/> as a modal
aelishRollo Jul 6, 2024
76292da
Refactor <ProjectView> to be a drop down rather than a modal
aelishRollo Jul 6, 2024
f9636c6
Adjust hamburger menu positioning
aelishRollo Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 146 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,18 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-scripts": "5.0.1",
"semantic-ui-css": "^2.5.0",
"semantic-ui-react": "^2.1.5",
"typescript": "^4.9.5",
"web-vitals": "^2.1.4"
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"build": "DISABLE_ESLINT_PLUGIN=true react-scripts build",
"test": "react-scripts test",
"test:ci": "react-scripts test --watchAll=false",
"eject": "react-scripts eject",
"lint": "eslint src/**/*.ts*",
"lint": "DISABLE_ESLINT_PLUGIN=false react-scripts build",
"fix": "npm run lint -- --fix",
"check-types": "tsc --noEmit",
"ci": "npm run lint && npm run check-types && npm run test:ci && npm run build"
Expand Down
38 changes: 0 additions & 38 deletions src/App.css
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import {useState} from 'react';

import './App.css';
import './css_reset.css'
import './index.css'
import './section_view.css';
import * as types from './types';
import {GlobalStoreProvider} from './hooks/useGlobalStore';
import SectionPage from './SectionPage';
import {IClient} from './client/IClient';
import {ClientProvider} from './hooks/useClient';
import {useMount} from './hooks/useMount';
import SectionView from './SectionView';

type AppProps = {
projectId: string;
Expand Down Expand Up @@ -51,10 +47,7 @@ const App: React.FC<AppProps> = ({projectId, sectionId, client}) => {
}

const pageContent = (
<SectionPage
projectId={projectId}
sectionId={sectionId}
/>
<SectionView/>
);

return (
Expand Down
Loading
Loading