Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full project compare No. 2 #2

Open
wants to merge 58 commits into
base: initial2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
309d86a
Get basic layout working
aelishRollo Apr 4, 2024
a572ce6
Add a CSS reset
aelishRollo Apr 4, 2024
05f13f5
Styles for intro
aelishRollo Apr 4, 2024
42c83ef
Add chord progression
aelishRollo Apr 4, 2024
ec9d7cd
Styles for the .chords div
aelishRollo Apr 4, 2024
524e0ca
Add styles for files
aelishRollo Apr 5, 2024
b82a3c7
Start writing styles for .comments
aelishRollo Apr 5, 2024
0c2cdd8
Add font awesome. Add comments section
aelishRollo Apr 6, 2024
c98d04d
Add submit styles
aelishRollo Apr 6, 2024
c36662a
Improve some code readability
aelishRollo Apr 6, 2024
3ecc9ef
Refactor CSS reset to its own file. Standardize naming conventions
aelishRollo Apr 12, 2024
b947804
Change .parent to .root
aelishRollo Apr 12, 2024
5119278
Make sectionData, currentChordProgression, files, and comments, data …
aelishRollo Apr 12, 2024
ad77205
Refactor files to be its own component
aelishRollo Apr 13, 2024
69a671d
Refactor ChordProgression into a component
aelishRollo Apr 13, 2024
627dc8f
Refactor Chordprogression for to include the <div> with class chords
aelishRollo Apr 13, 2024
233b7e8
Refactor Files so <div> with class 'files' is all together
aelishRollo Apr 13, 2024
eb84b11
Refactor comments section into its own component
aelishRollo Apr 13, 2024
812d456
Refactor submit section into its own component
aelishRollo Apr 13, 2024
3b2d7e2
Refactor Section-Title into its own component
aelishRollo Apr 13, 2024
b0cd8b4
Give all component return statements pretty parentheses
aelishRollo Apr 20, 2024
aaeaec0
Refactor sectionData to be passed in as a prop
aelishRollo Apr 22, 2024
cf1bde7
Refactor chord progression component to use props
aelishRollo Apr 23, 2024
660977c
Refactor files component to use props
aelishRollo Apr 23, 2024
b494a52
Refactor Comments to use props
aelishRollo Apr 23, 2024
4dbcfec
Add an id for the array of files
aelishRollo Apr 24, 2024
22e7c24
Move type definitions to Types.ts
aelishRollo Apr 24, 2024
ae941bd
Add types to testData.ts
aelishRollo Apr 25, 2024
11c9a6e
Remove unnecessary import
aelishRollo Apr 25, 2024
ca323bb
Add export keywords to testData.ts
aelishRollo Apr 25, 2024
72db333
Move all data to testData.tsx
aelishRollo Apr 25, 2024
631ef8a
Refactor App.tsx to accept testData as a prop
aelishRollo Apr 26, 2024
4a263fc
Prepare to refactor components to their own files
aelishRollo Apr 26, 2024
41a8b2e
Refactor components to their own files
aelishRollo Apr 26, 2024
8855891
Add comments as state variable, hoist it
aelishRollo Apr 27, 2024
7620d10
Remove extra map from .submit
aelishRollo Apr 27, 2024
ac1ea6c
Rename Submit component to CreateComment
aelishRollo Apr 27, 2024
b06a3d4
Fix comment update bug
aelishRollo Apr 30, 2024
4fa90a9
Remove unnecessary imports
aelishRollo Apr 30, 2024
763e61f
Fix overflow issue when adding a new comment
aelishRollo Apr 30, 2024
948eaab
Make all types start with uppercase character
aelishRollo May 1, 2024
8413354
Move AppProps to App.jsx
aelishRollo May 1, 2024
b18ed6a
Move CreateCommentProps to CreateComment.tsx
aelishRollo May 1, 2024
b0b6b80
Move FilesProps definition to Files.tsx
aelishRollo May 1, 2024
9390c2d
Move ChordProgressionProps to ChordProgression.tsx
aelishRollo May 1, 2024
b9c09d0
Move SectionDataProps to SectionData.tsx
aelishRollo May 1, 2024
4b48b2c
Change 'Types' to 'types'
aelishRollo May 1, 2024
5842ae0
Change '.buttons' to '.revisions'
aelishRollo May 2, 2024
b949d42
User can now rename section title
aelishRollo May 3, 2024
7676ef0
Add parenthese to returned JSX
aelishRollo May 3, 2024
70206b1
Make amount of comments show on page
aelishRollo May 3, 2024
dff866e
Prep to move to localStorage
aelishRollo May 7, 2024
371de77
Make comments persistant using localStorage
aelishRollo May 8, 2024
2b25ef6
Rename testData.tsx to sampleData.tsx
aelishRollo May 8, 2024
8efdec6
Move comments data to localStorage
aelishRollo May 9, 2024
524408f
Create ci workflows for build and type checking (#7)
mickmister May 12, 2024
571c1b0
Update README.md
aelishRollo May 24, 2024
bc5af78
Refactor to use local storage (#8)
mickmister Jun 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"extends": [
"react-app",
"react-app/jest"
],
"rules": {
"testing-library/no-container": "off",
"testing-library/no-node-access": "off"
}
}
66 changes: 66 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: CI

on:
push:
branches:
- main
pull_request:
branches:
- '**'
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 21
cache: 'npm'
- name: Install modules
run: npm i
- name: Build app
run: npm run build
types:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 21
cache: 'npm'
- name: Install modules
run: npm i
- name: Check Types
run: npm run check-types

lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 21
cache: 'npm'
- name: Install modules
run: npm i
- name: Run eslint
run: npm run lint

test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 21
cache: 'npm'
- name: Install modules
run: npm i
- name: Run tests
run: npm run test:ci
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@
npm-debug.log*
yarn-debug.log*
yarn-error.log*

_ignore
3 changes: 3 additions & 0 deletions .gitpod.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
tasks:
- init: npm install && npm run build
command: npm run start
41 changes: 7 additions & 34 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,46 +1,19 @@
# Getting Started with Create React App
## Section-View: a new tool for musical composition

This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).

## Available Scripts

In the project directory, you can run:
### Section view is a collaborative pre-DAW music application

### `npm start`
## Tech Used: ![JAVASCRIPT BADGE](https://img.shields.io/static/v1?label=|&message=JAVASCRIPT&color=3c7f5d&style=plastic&logo=javascript) ![React Badge](https://img.shields.io/static/v1?label=|&message=REACT&color=61DAFB&style=plastic&logo=react)![TypeScript Badge](https://img.shields.io/static/v1?label=|&message=TypeScript&color=3178C6&style=plastic&logo=typescript)

Runs the app in the development mode.\
Open [http://localhost:3000](http://localhost:3000) to view it in the browser.

The page will reload if you make edits.\
You will also see any lint errors in the console.

### `npm test`

Launches the test runner in the interactive watch mode.\
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.

### `npm run build`
## Optimizations

Builds the app for production to the `build` folder.\
It correctly bundles React in production mode and optimizes the build for the best performance.
This project is constantly improving and growing. We're working on extending the scope of the project as you read this

The build is minified and the filenames include the hashes.\
Your app is ready to be deployed!
## Lessons Learned:

See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.

### `npm run eject`

**Note: this is a one-way operation. Once you `eject`, you can’t go back!**

If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.

You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.

## Learn More

You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).

To learn React, check out the [React documentation](https://reactjs.org/).
Learned quite a bit about managing complexity and writing scalable and maintainable code
74 changes: 74 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@fortawesome/fontawesome-svg-core": "^6.5.2",
"@fortawesome/free-brands-svg-icons": "^6.5.2",
"@fortawesome/free-regular-svg-icons": "^6.5.2",
"@fortawesome/free-solid-svg-icons": "^6.5.2",
"@fortawesome/react-fontawesome": "^0.2.0",
"@testing-library/jest-dom": "^5.17.0",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
Expand All @@ -20,13 +25,12 @@
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"
},
"eslintConfig": {
"extends": [
"react-app",
"react-app/jest"
]
"test:ci": "react-scripts test --watchAll=false",
"eject": "react-scripts eject",
"lint": "eslint src/**/*.ts*",
"fix": "npm run lint -- --fix",
"check-types": "tsc --noEmit",
"ci": "npm run lint && npm run check-types && npm run test:ci && npm run build"
},
"browserslist": {
"production": [
Expand Down
Loading
Loading