Update Mailkit and Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmh
approved these changes
Nov 18, 2024
|
Thanks! |
|
Any special reason why the Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation package is at version 6? |
|
Some packages were upgrade to 6.x.x whenever Coravel first began to support dotnet 6. Not sure if there was a specific reason on this one though as far new functionality that was needed, breaking changes, etc. 🤷 |
|
Would you want me to upgrade every packages so we target .Net 8 and + ? Net 6 and net 7 is reaching end of life this year Also I dont know about if I could remove Newtonsoft json from dependencies and target only STJ whats your thoughts about all that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Mailkit from 4.3.x to 4.8.x
Update Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation from 6.0.27 to 6.0.36
This will also fix vulnerabilities issues
Thanks