Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Commit

Permalink
### Bug Fixes
Browse files Browse the repository at this point in the history
* Fixed issue where main processes continually runs when not all playlists have been processes
* Added additional logging for playlists processing - Attempting to troubleshoot 'object instance not set to an instance of an object' a few people are getting trying to upload their playlists
  • Loading branch information
jamesbrindle committed May 8, 2021
1 parent 9fca6fc commit 2043498
Show file tree
Hide file tree
Showing 10 changed files with 195 additions and 105 deletions.
8 changes: 4 additions & 4 deletions Installer-x64/Installer-x64.vdproj
Original file line number Diff line number Diff line change
Expand Up @@ -7921,15 +7921,15 @@
{
"Name" = "8:Microsoft Visual Studio"
"ProductName" = "8:YT Music Uploader"
"ProductCode" = "8:{865865AA-2AAE-44BC-A574-3BDBF6994287}"
"PackageCode" = "8:{B09324DB-FC08-4A83-B237-7AAA83AE80AF}"
"ProductCode" = "8:{C8936624-2CB9-4293-9158-836C0B580465}"
"PackageCode" = "8:{51917E0C-BA3C-4DDC-ABCC-6730B38C1D88}"
"UpgradeCode" = "8:{AB84D0C0-CDF7-4BDF-90B0-C4808DB11DAB}"
"AspNetVersion" = "8:4.0.30319.0"
"RestartWWWService" = "11:FALSE"
"RemovePreviousVersions" = "11:TRUE"
"DetectNewerInstalledVersion" = "11:TRUE"
"InstallAllUsers" = "11:FALSE"
"ProductVersion" = "8:1.7.5"
"ProductVersion" = "8:1.7.6"
"Manufacturer" = "8:JB-Net Software Solutions"
"ARPHELPTELEPHONE" = "8:"
"ARPHELPLINK" = "8:https://github.com/jamesbrindle/YTMusicUploader/issues"
Expand Down Expand Up @@ -8435,7 +8435,7 @@
{
"{5259A561-127C-4D43-A0A1-72F10C7B3BF8}:_3AB76FEAD3A849FBB271E712B0EA59C3"
{
"SourcePath" = "8:..\\YTMusicUploader\\obj\\x64\\Release\\YTMusicUploader.exe"
"SourcePath" = "8:"
"TargetName" = "8:"
"Tag" = "8:"
"Folder" = "8:_B3B65ED76DD54A94A22A406398263B40"
Expand Down
8 changes: 4 additions & 4 deletions Installer-x86/Installer.vdproj
Original file line number Diff line number Diff line change
Expand Up @@ -7921,15 +7921,15 @@
{
"Name" = "8:Microsoft Visual Studio"
"ProductName" = "8:YT Music Uploader"
"ProductCode" = "8:{6D61441E-0BC8-40EF-8914-DCEF6EB7A452}"
"PackageCode" = "8:{3408BA7F-A292-442F-8468-C81463367967}"
"ProductCode" = "8:{371194FD-F572-4C8A-8DCF-F4D3854BAC0E}"
"PackageCode" = "8:{4F39C7CF-9A3F-4080-A6FD-C0DCF8890968}"
"UpgradeCode" = "8:{1E18ED3F-C210-4589-BEB4-58E2680D3C71}"
"AspNetVersion" = "8:4.0.30319.0"
"RestartWWWService" = "11:FALSE"
"RemovePreviousVersions" = "11:TRUE"
"DetectNewerInstalledVersion" = "11:TRUE"
"InstallAllUsers" = "11:FALSE"
"ProductVersion" = "8:1.7.5"
"ProductVersion" = "8:1.7.6"
"Manufacturer" = "8:JB-Net Software Solutions"
"ARPHELPTELEPHONE" = "8:"
"ARPHELPLINK" = "8:https://github.com/jamesbrindle/YTMusicUploader/issues"
Expand Down Expand Up @@ -8435,7 +8435,7 @@
{
"{5259A561-127C-4D43-A0A1-72F10C7B3BF8}:_858C89B90B894F97A8CDE5C10D88F13E"
{
"SourcePath" = "8:..\\YTMusicUploader\\obj\\x86\\Release\\YTMusicUploader.exe"
"SourcePath" = "8:"
"TargetName" = "8:"
"Tag" = "8:"
"Folder" = "8:_1059907B4555471C9BCCD73D3FBBCC93"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Automatically upload your local personal music library to YouTube Music and bulk
 
 

**[Download Version 1.7.5 Installer](https://github.com/jamesbrindle/YTMusicUploader/releases/tag/v1.7.5)**
**[Download Version 1.7.6 Installer](https://github.com/jamesbrindle/YTMusicUploader/releases/tag/v1.7.6)**
 
 

Expand Down
15 changes: 6 additions & 9 deletions YTMusicUploader/Business/FileScanner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,12 @@ public void Process()
}
catch (Exception e)
{
if (!e.Message.Contains("Thread was being aborted"))
{
Logger.Log(
e,
"FileScanner.Process - Error reading file (possibly removed): " +
file.Path,
Log.LogTypeEnum.Error,
false);
}
Logger.Log(
e,
"FileScanner.Process - Error reading file (possibly removed): " +
file.Path,
Log.LogTypeEnum.Error,
false);
}
}
}
Expand Down
22 changes: 2 additions & 20 deletions YTMusicUploader/Business/FileUploader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,7 @@ public async Task Process()
}
catch (Exception e)
{
if (e.Message.ToLower().Contains("thread was being aborted") ||
(e.InnerException != null && e.InnerException.Message.ToLower().Contains("thread was being aborted")))
{
// Non-detrimental - Ignore to not clog up the application log
// Logger.Log(e, "Process.Process", Log.LogTypeEnum.Warning);
}
else
{
Logger.Log(e, "Process.Process", Log.LogTypeEnum.Critical);
}
Logger.Log(e, "Process.Process", Log.LogTypeEnum.Critical);
}
}
else
Expand All @@ -196,16 +187,7 @@ public async Task Process()
}
catch (Exception e)
{
if (e.Message.ToLower().Contains("thread was being aborted") ||
(e.InnerException != null && e.InnerException.Message.ToLower().Contains("thread was being aborted")))
{
// Non-detrimental - Ignore to not clog up the application log
// Logger.Log(e, "Process.Process", Log.LogTypeEnum.Warning);
}
else
{
Logger.Log(e, "Process.Process", Log.LogTypeEnum.Critical);
}
Logger.Log(e, "Process.Process", Log.LogTypeEnum.Critical);
}

if (MainForm.ManagingYTMusicStatus != ManagingYTMusicStatusEnum.Showing)
Expand Down
Loading

0 comments on commit 2043498

Please sign in to comment.