Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/fix scheme #140

Closed
wants to merge 3 commits into from
Closed

Conversation

Catharsis68
Copy link
Contributor

No description provided.

Copy link
Collaborator

@davehorton davehorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a default assignment in the constructor

this.scheme = 'sip';

then we can just override it where necessary

@Catharsis68
Copy link
Contributor Author

Please add a default assignment in the constructor

this.scheme = 'sip';

then we can just override it where necessary

it is already in the constructor - line 92

@davehorton
Copy link
Collaborator

@Catharsis68 I've taken your branch and created a new PR with changes I think were needed:

#141

Could you try testing that PR?

@davehorton
Copy link
Collaborator

closed in favor of #141

@davehorton davehorton closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants