Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/obscure sensitive bucket credentials #375

Merged

Conversation

Catharsis68
Copy link
Contributor

@Catharsis68 Catharsis68 commented Jan 2, 2025

  • obscure sensitive data before sending
  • test bucket credentials based on the stored account credentials (since the displayed credentials contain obscured data)
  • if FE sends obscured data, replace it with stored one before storing it in the database
  • Checkbox of call recording is selected properly (webapp)
  • add test suite for isObscureKey and obscureBucketCredentialsSensitiveData

How to test

Bucket Credentials Test - unsaved

  • If you define new bucket credentials - and click on test
    • these credentials from the req.body will be used

Bucket Credentials Test - saved

  • If the account had been saved and cou click on test test
    • the credentials stored in the db will be used

Account - create

  • If you define new bucket credentials - and click on save
    • these credentials will be used

Account - bucket credentials - update

  • If you update the bucket credentials - and click on save
    • these credentials from the req.body will be used

Account - update

  • If you update anything from the account- but not the credentials secrets - and click on save
    • the credentials stored in the db will be used

@davehorton davehorton merged commit 23cd440 into jambonz:main Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants