Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployer to newer version #72

Closed
wants to merge 11 commits into from
Closed

Update deployer to newer version #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f803a09
Update deployer to newer version
Dec 17, 2020
d0af169
Update travis instances.
Dec 17, 2020
2293a42
Fixing Travis build
Dec 17, 2020
7345f69
Fixing Travis build
Dec 17, 2020
c2b5783
Fixing Travis build
Dec 17, 2020
7683cb3
Fixing Travis build
Dec 17, 2020
008bf6c
Fixing Travis build
Dec 17, 2020
6331c28
Fixing Travis build
Dec 17, 2020
7104838
Fixing Travis build
Dec 17, 2020
276121b
Fixing Travis build
Dec 17, 2020
f098d6f
Fixing Travis build
Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
language: php

php:
- 7.0
- 7.1
- 7.2
- 7.3
- 7.4

before_install:
- sudo apt-get -qq update

install:
- composer self-update
- php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
- php -r "if (hash_file('sha384', 'composer-setup.php') === '756890a4488ce9024fc62c56153228907f1545c228516cbf63f885e036d37e9a59d27d63f46af1d4d07ee0f76181c7d3') { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;"
- php composer-setup.php --version=1.10.19
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- php composer-setup.php --version=1.10.19
- php composer-setup.php --1

Why do we fix this to a specific version? I suggest using at least the latest v1 version. Or can we even switch to v2?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this with Composer 2 just fine, so it probably could do without a version

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, composer 2 is now supported on both 2.3 and 2.4, so I agree that there's no need to hardcore composer version to v1

- php -r "unlink('composer-setup.php');"
- composer install

script:
Expand Down
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
}
],
"require": {
"deployer/dist": "^6.0"
"php": "~7.2.0||~7.3.0||~7.4.0",
"deployer/deployer": "^6.8"
},
"require-dev": {
"phpro/grumphp": "^0.14.0",
"phpro/grumphp": "^0.18.0",
"phpmd/phpmd": "^2.6",
"nikic/php-parser": "^3.1",
"squizlabs/php_codesniffer": "^3.2",
Expand Down