methods return array #43

AhmadMrf · 2022-11-26T14:28:00Z

methods return array instead of object , for easier destructuring

jalaali.toJalaali(2016, 4, 11) // [1395, 1, 23 ]

jalaali.toGregorian(1395, 1, 23) // [ 2016, 4, 11 ]

jalaali.jalaaliWeek(1400, 4, 30) // { saturday: [ 1400,  4,  26 ], friday: [ 1400,  5, 1 ] }

let [year, month, day] = jalaali.toJalaali(2016, 4, 11)

methods return array[year,month,day] instead of object{jy,jm,jd} , for easier destructuring.

methods return array instead of object , for easier destructuring

behrang · 2023-01-08T07:55:08Z

Hey, thanks for the pull request. However, this change breaks users' code that is already using these functions. So, I have to reject it.

AhmadMrf added 2 commits November 26, 2022 17:45

methods return array

962a17a

methods return array[year,month,day] instead of object{jy,jm,jd} , for easier destructuring.

methods return array

d1b8ba6

methods return array instead of object , for easier destructuring

AhmadMrf changed the title ~~Patch 1~~ methods return array Nov 26, 2022

AhmadMrf added 2 commits November 26, 2022 18:15

Update index.js

ede8ece

Update README.md

c15f4ef

behrang closed this Jan 8, 2023

AhmadMrf deleted the patch-1 branch January 19, 2023 10:21

Provide feedback