Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jalaaliToTimestamp function #31

Closed
wants to merge 1 commit into from
Closed

Add jalaaliToTimestamp function #31

wants to merge 1 commit into from

Conversation

sajadspeed
Copy link
Contributor

This function is simple but is useful

@behrang
Copy link
Member

behrang commented Sep 18, 2021

Hi,

Thanks for the contribution, however, I'm against such utility helpers. The function jalaaliToDateObject returns a Date object, and prefixing it with a + returns the timestamp, so it is shorter, and doesn't need another method to remember to use.

@behrang behrang closed this Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants