Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test completion #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Test completion #1

wants to merge 3 commits into from

Conversation

ctournaire
Copy link

Hi Jackson,

Here is the pull request for the betterform coding exercise.
I implemented the features you suggested and implemented a small functional test. I could have gone further implementing units tests and UI test (using Jasmine) but I ran out of time (it's been quite a busy week-end).

Note that I used and modified a version of HTML 5 Boilerplate with Twitter Bootstrap on top of it. I didn't usea JS framework because I thought jQuery what sufficient for the few calls needed for async validation and submit. Styling could certainly be improved and I always enjoy doing front-end work from a photoshop layout but honestly I am not a great designer myself.

I hope you'll like the result. In any case, comments and feedback would be much appreciated.

Have a good start of week,
Chris

@jakxnz
Copy link
Owner

jakxnz commented May 29, 2017

Hey @ctournaire,

Awesome, thanks for submitting a pull request. I think you approached the exercise really well, you stayed with technologies that you could support in a limited timeframe, and you thought of things that weren't covered in the suggestions for the exercise. There's a few comments I might make in a peer review, but that's not the point of the exercise.

I'll give my review to the team at Tax Traders.

Thanks for completing the task!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants