cleanup actions

jakubwro · Sep 28, 2023 · 7996991 · 7996991
1 parent 42efd59
commit 7996991
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/.github/workflows/benchmark.yml → .github/workflows/benchmarks.yml b/.github/workflows/benchmark.yml → .github/workflows/benchmarks.yml
@@ -22,7 +22,7 @@ jobs:
 
     # TODO: cannot enable jetstream this way, added "Start nats with jetstream step."
     services:
-      nats-unused:
+      nats:
         image: nats:${{ matrix.nats-version }}
         ports:
           - 4222:4222

diff --git a/.github/workflows/test.yml → .github/workflows/runtests.yml b/.github/workflows/test.yml → .github/workflows/runtests.yml
@@ -15,29 +15,27 @@ jobs:
       matrix:
         julia-version: ['1.9.3']
         julia-arch: [x64]
-        nats-version: ['2.10.1']
+        nats-version: ['2.9', '2.10.1']
         julia-num-threads: ['1', '1,1'] # TODO: add ['1,4', '4,4'], but it require large runner, default there are only 2 cores. 
         os: [ubuntu-latest]
 
 
     # TODO: cannot enable jetstream this way, added "Start nats with jetstream step."
     services:
-      nats-unused:
+      nats:
         image: nats:${{ matrix.nats-version }}
-        # ports:
-          # - 4222:4222
+        ports:
+          - 4222:4222
 
     steps:
-      - name: "Start nats with jetstream"
-        run: |
-          docker network ls
-          echo ${{ job.container.network }}
-          name=`docker create --name nats --network ${{ job.container.network }} --network-alias nats -p 4222:4222 -e GITHUB_ACTIONS=true -e CI=true nats:2.10.1 --jetstream`
-          docker container start $name
+      # - name: "Start nats with jetstream"
+      #   run: |
+      #     docker network ls
+      #     echo ${{ job.container.network }}
+      #     name=`docker create --name nats --network ${{ job.container.network }} --network-alias nats -p 4222:4222 -e GITHUB_ACTIONS=true -e CI=true nats:2.10.1 --jetstream`
+      #     docker container start $name
       - name: "Start reply service"
         run: |
-          docker ps
-          docker network ls
           name=`docker create --network ${{ job.container.network }} -e GITHUB_ACTIONS=true -e CI=true --entrypoint nats synadia/nats-box:latest --server nats:4222 reply help.please 'OK, I CAN HELP!!!'`
           container_id=`docker container start $name`
           sleep 2