Bug: incorrect graph displayed #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
added a commit
to Vrixyz/bevy_rapier
that referenced
this pull request
Sep 11, 2024
I'm not totally convinced yet, this leads to unfortunate API impacts to users, + bevy_mod_debugdump a bit difficult to parse, see jakobhellermann/bevy_mod_debugdump#50
|
as of 49d21ca ; the output looks like that:
Real project example output
More context
I tried to use functions from petgraph but was only greeted by difficulties:
I dropped the idea of using petgraph "correctly" and focused on getting somewhat of a progress |
Vrixyz
commented
Sep 18, 2024
|
|
||
| /// Formats the schedule into a dot graph. | ||
| pub fn schedule_graph_dot(schedule: &Schedule, world: &World, settings: &Settings) -> String { | ||
| let graph = schedule.graph(); | ||
| let hierarchy = graph.hierarchy().graph(); | ||
| let dependency = graph.dependency().graph(); | ||
| let dependency = &mut graph.dependency().graph().clone(); | ||
| remove_transitive_edges(dependency); |
There was a problem hiding this comment.
This might benefit being an option, or fix within bevy (chain() logic which might be the original culprit, but needs a lot more investigation so I'd make that a follow up only if needed.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if the bug is originating from this crate or bevy, but it seems weird that
system_no_setis linked tosystem_in_child_set2(green arrow should not exist).Real project example
From Split RapierContext dimforge/bevy_rapier#585
Current output from bevy_mod_debugdump: