Add support for LSB-encoded TIFF images. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this merge fully resolve issue #37? Is there a reason it has been ignored for almost a full year? I am currently experiencing the same issue with the TIFFLZWDecompressor. |
|
@SethChampagneNRL I don't know, but it looks like it, as it seems to add full support for LSB. This issue has been more overseen than ignored. As the pull request only adds new code in the case of (previously broken) LSB-encoded files I think it's better to merge and see if it fully resolves #37. |
|
I should mention that I used a local build of this branch and it resolved the NullPointerException issue I was having. I was able to read the compressed tiff. I appreciate the merge. |
marpet
pushed a commit
to senbox-org/imageio-ext
that referenced
this pull request
Apr 27, 2020
taken from jai-imageio/jai-imageio-core#39 Issue geosolutions-it#37 support for LSB LWZ compressed TIFF
marpet
added a commit
to senbox-org/imageio-ext
that referenced
this pull request
May 5, 2020
* set intermediate version * FiX: TIFFLZWDecompressor Null Pointer Exception taken from jai-imageio/jai-imageio-core#39 Issue geosolutions-it#37 support for LSB LWZ compressed TIFF * synchronised super.decode() call to try to avoid NPE java.lang.NullPointerException at it.geosolutions.imageio.plugins.tiff.TIFFDecompressor.decode(TIFFDecompressor.java:2925) at it.geosolutions.imageioimpl.plugins.tiff.TIFFNullDecompressor.decode(TIFFNullDecompressor.java:174) at it.geosolutions.imageioimpl.plugins.tiff.TIFFImageReader.decodeTile(TIFFImageReader.java:1798) * set version to 1.3.3.2-SNAP Co-authored-by: Luca Bellonda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and tests for issue #37. Please, review the changes, since the impact on the LZW decoder can be huge.