Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance template preRun and postRun options and add templating docs #177

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Oct 11, 2024

Summary

Variety of templating updates, including docs updates

Notable Changes

  • Fixes docs generation for templates
  • Adds content to the templating guide
  • Accepts templating in the preRun and postRun fields
  • Fixes handling of preRun and postRun args

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 39.24051% with 48 lines in your changes missing coverage. Please review.

Project coverage is 37.32%. Comparing base (9a98046) to head (3c38fc3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/templates/templates.go 54.16% 13 Missing and 9 partials ⚠️
types/executable/executable_md.go 0.00% 18 Missing ⚠️
internal/templates/form.go 38.46% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   37.38%   37.32%   -0.07%     
==========================================
  Files          81       81              
  Lines        5716     5769      +53     
==========================================
+ Hits         2137     2153      +16     
- Misses       3149     3181      +32     
- Partials      430      435       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Includes several templating updates, mostly centered around improving
the experience with running preRun and postRun executables by switching
to a refConfig instead of using the Exec executable type.
@jahvon jahvon force-pushed the template-imptovements branch from b276f7d to 3c38fc3 Compare October 11, 2024 18:15
@jahvon jahvon marked this pull request as ready for review October 11, 2024 18:16
@jahvon jahvon merged commit c50e5a0 into main Oct 11, 2024
8 checks passed
@jahvon jahvon deleted the template-imptovements branch October 11, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant