Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add new exec verbs and update subcmd usage #162

Merged
merged 3 commits into from
Sep 24, 2024
Merged

feat!: add new exec verbs and update subcmd usage #162

merged 3 commits into from
Sep 24, 2024

Conversation

jahvon
Copy link
Owner

@jahvon jahvon commented Sep 24, 2024

Summary

flow get, set, remove, and list commands are refactored to create flow template, secret, config, and workspace instead. This allows for using those verbs as new executable verbs; along with many more verbs and verb groups.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

All commands under set, init, get, and remove have been moved under
their noun replacements (i.e. init config -> config init).

This is a first step to reserving verbs for only exec command aliases.
Adds a bunch of exec verbs and updates the new subcommand names post-
reorganization. Includes generated docs and tests updates
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 49.76888% with 326 lines in your changes missing coverage. Please review.

Project coverage is 36.41%. Comparing base (57bcd5a) to head (f709599).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/internal/workspace.go 25.28% 126 Missing and 4 partials ⚠️
cmd/internal/library.go 30.00% 68 Missing and 2 partials ⚠️
cmd/internal/secret.go 65.29% 42 Missing and 17 partials ⚠️
cmd/internal/config.go 52.77% 32 Missing and 2 partials ⚠️
cmd/internal/template.go 74.41% 23 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   36.29%   36.41%   +0.11%     
==========================================
  Files          82       81       -1     
  Lines        5686     5682       -4     
==========================================
+ Hits         2064     2069       +5     
+ Misses       3218     3207      -11     
- Partials      404      406       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahvon jahvon changed the title Commands feat!: add new exec verbs and update subcmd usage Sep 24, 2024
@jahvon jahvon merged commit 29daebf into main Sep 24, 2024
5 checks passed
@jahvon jahvon deleted the commands branch September 24, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant