Skip to content

Commit

Permalink
build(lint): Update lint step to run.
Browse files Browse the repository at this point in the history
- Update eslint job to latest agent versions
- Update eslint packages and migrate config to eslint.config format
NOTE:
- testing-library commented out (not compatbile)
- comment out wearerequired/lint-action@v2 action and replace with pnpm run lint, (not compatbile eslint9)
  • Loading branch information
jafin committed Jul 12, 2024
1 parent 32c370b commit cbea225
Show file tree
Hide file tree
Showing 6 changed files with 857 additions and 856 deletions.
16 changes: 0 additions & 16 deletions .eslintignore

This file was deleted.

164 changes: 0 additions & 164 deletions .eslintrc.cjs

This file was deleted.

19 changes: 12 additions & 7 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:

steps:
- name: Check out Git repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}

Expand All @@ -38,8 +38,13 @@ jobs:
- name: Install dependencies
run: pnpm i

- name: Run linters
uses: wearerequired/lint-action@v2
with:
eslint: true
prettier: false #runs part of eslint
- name: Run lint
run: pnpm run lint

# Currently incompatible with ESlint 9 (https://github.com/wearerequired/lint-action/pull/799)
# - name: Run linters
# uses: wearerequired/lint-action@v2
# with:
# eslint: true
# prettier: false #runs part of eslint
# autofix: false #does not work well with pull requests https://github.com/wearerequired/lint-action?tab=readme-ov-file#limitations
Loading

0 comments on commit cbea225

Please sign in to comment.