-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for request through ssl #64
base: master
Are you sure you want to change the base?
Conversation
@jadell I added a simple DI class which may solve the problems with the configurations. The idea is to keep there configuration variables and things such as closures for creating nodes/relationships...etc. I also added a bootstrap file with some initial dependencies to be populated in the DI (Bootstrap.php). Putting more object initialization callbacks in the DI will also allow easier extension of the library. |
I like where this is going, but I'd like to make a few changes. It's similar to the "Configuration" class I was thinking of introducing. I'm going to merge this into a branch and tweak it a bit, if that's okay. |
Add options to the transport for ssl request.
Example:
$transport = new Transport\Curl("127.0.0.1", "443");
$sslOptions = array(CURLOPT_SSL_VERIFYPEER => true, CURLOPT_SSLCERT => "/path/to/cert");
$transport->useHttps(true, $sslOptions);
OR
$transport = new Transport\Stream("127.0.0.1", 443);
$sslOptions = array("verify_peer" => false, "cafile" => "path/to/cafile);
$transport->useHttps(true, $sslOptions);
Also when sending request through ssl with context_stream the stream_options array must be with key http for the http options and the ssl specific option must be with key ssl.