Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial #147

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Spatial #147

wants to merge 6 commits into from

Conversation

tomcorbett
Copy link

Updated compser.json and fixed unit test

- addSimplePointLayer
- addNodeToLayer
- getLayer
- findGeometriesWithinDistance
- findGeometriesInBBox
Added:
- addSimplePointLayer
- addNodeToLayer
- getLayer
- findGeometriesWithinDistance
- findGeometriesInBBox

First working version, not fully unit tested but tested functionality
and works
@@ -1,12 +1,13 @@
{
"name": "everyman/neo4jphp",
"name": "tomcorbett/neo4jphp",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing package name ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kwattro sorry I have been away for 2 weeks so just seeing this now. Anything I changed was because I was branching off of this project as after speaking to @jadell he didn't have time to review and advised I just forked and continued using my fork, so I am for now as I am actively using this library in one of my own projects.

If we do get some people to review my changes of course I will go through all changes with them and happy to change everything back.

@mmeloni
Copy link

mmeloni commented Sep 25, 2017

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants