-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to reuse stream parsing across ChatModels #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big refactor. Replaces near-duplicate generator functions with better abstractions.
To parse an LLM streamed response now requires
StreamParser
to identify string vs tool and parse theseStreamState
to keep track of current message snapshot, usage, etc. for a streamed responseThis removes the assumption that the LLM returns either string or tool calls, in preparation for #232
Improved parsing of output types. So now
FunctionCall
orParallelFunctionCall
is required in the return type of the prompt-function rather than allowing these to be returned when not in the type.Also added new error types
FunctionCallNotAllowedError
,ObjectNotAllowedError
,UnknownToolError
which can be added to the LLM-assisted retry logic in future.