cache database on client

.dockerignore

@@ -3,4 +3,4 @@
 **/dist
 **/.git
 **/.github
-screenshots
+traces

.eslintignore

@@ -1,7 +1,7 @@
 .idea/
 .github/
 docker/
-screenshots/
+traces/
 **/*.min.js
 **/build/
 **/dist/

.eslintrc.js

@@ -12,16 +12,11 @@ const {
 module.exports = {
   settings: {
     react: {
-      version: '17.0.2', // note: remember to always keep this in sync with `"react": "^17.0.2",` which is present in any package.json of a project using React.
+      version: 'detect',
     },
   },
   parser: '@typescript-eslint/parser',
   parserOptions: {
-    project: [
-      './tsconfig.eslint.json',
-      './packages/*/tsconfig.json',
-      './plugins/*/tsconfig.json',
-    ],
     tsconfigRootDir: __dirname,
     ecmaFeatures: {
       jsx: true,
@@ -73,15 +68,12 @@ module.exports = {
     'array-bracket-spacing': ERROR,
     'brace-style': SUCCESSOR(TYPESCRIPT_EXTENSION),
     'block-spacing': ERROR,
-    'camelcase': [ERROR, { allow: ['__export_format', '__export_date', '__export_source'] }],
     'comma-dangle': [ERROR, 'always-multiline'],
     'comma-spacing': ERROR,
     'consistent-return': OFF('found to be too many false positives'),
     'curly': ERROR,
     'default-case': ERROR,
     'default-case-last': ERROR,
-    'filenames/match-exported': [ERROR, 'kebab'],
-    'indent': [ERROR, 2, { SwitchCase: 1 }],
     'eol-last': [ERROR, 'always'],
     'eqeqeq': [ERROR, 'smart'],
     'arrow-parens': [ERROR, 'as-needed'],
@@ -113,17 +105,15 @@ module.exports = {
       ],
     }],
 
-    'react/no-find-dom-node': OFF(UNKNOWN),
     'react/no-unescaped-entities': OFF(TYPESCRIPT_CONVERSION),
     'react/jsx-first-prop-new-line': [ERROR, 'multiline'],
     'react/jsx-max-props-per-line': [ERROR, { maximum: 1, when: 'multiline' }],
     'react/jsx-uses-react': ERROR,
     'react/jsx-uses-vars': ERROR,
-    'react/jsx-indent': [ERROR, 2],
     'react/jsx-indent-props': [ERROR, 2],
     'react/prop-types': OFF(UNKNOWN),
     'react/function-component-definition': [ERROR, {
-      'namedComponents':  'arrow-function',
+      'namedComponents': 'arrow-function',
       'unnamedComponents': 'arrow-function',
     }],
     'react/jsx-closing-bracket-location': [ERROR, 'line-aligned'],
@@ -150,11 +140,19 @@ module.exports = {
     '@typescript-eslint/no-namespace': [ERROR, { allowDeclarations: true }],
     '@typescript-eslint/no-redeclare': ERROR,
     '@typescript-eslint/no-unused-vars': [ERROR, { ignoreRestSiblings: true }],
-    '@typescript-eslint/no-use-before-define': ERROR,
     '@typescript-eslint/space-infix-ops': ERROR,
     '@typescript-eslint/semi': [ERROR, 'always'],
     '@typescript-eslint/quotes': [ERROR, 'single', { avoidEscape: true }],
 
     'simple-import-sort/imports': ERROR,
+    'filenames/match-exported': OFF(UNKNOWN),
+    camelcase: OFF(UNKNOWN),
+    '@typescript-eslint/no-use-before-define': OFF(TYPESCRIPT_CONVERSION),
+    '@typescript-eslint/no-explicit-any': OFF(TYPESCRIPT_CONVERSION),
+    'react/no-find-dom-node': OFF(UNKNOWN),
+    'no-restricted-properties': [ERROR, {
+      property: 'openExternal',
+      message: 'use the `window.main.openInBrowser` function instead.  see https://security.stackexchange.com/questions/225799/dangers-of-electrons-shell-openexternal-on-untrusted-content for more information.',
+    }],
   },
 };

.github/workflows/changelog.yml

@@ -17,7 +17,7 @@ concurrency:
 
 jobs:
   parse-version:
-    if: "startsWith(github.head_ref, 'release/') || github.event_name == 'workflow_dispatch'"
+    if: ${{ startsWith(github.head_ref, 'release/') || github.event_name == 'workflow_dispatch' }}
     runs-on: ubuntu-latest
     outputs:
       version: ${{ steps.version.outputs.version }}
@@ -29,7 +29,7 @@ jobs:
           echo "RELEASE_VERSION=${{ github.event.inputs.version }} " >> $GITHUB_ENV
 
       - name: Set release version Env (pull_request)
-        if: "startsWith(github.head_ref, 'release/')"
+        if: ${{ startsWith(github.head_ref, 'release/') }}
         shell: bash
         run: |
           echo "RELEASE_VERSION=${BRANCH/release\//} " >> $GITHUB_ENV
@@ -152,10 +152,12 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version-file: '.nvmrc'
+          node-version-file: ".nvmrc"
+          cache: 'npm'
+          cache-dependency-path: package-lock.json
 
-      - name: Bootstrap packages
-        run: npm run bootstrap
+      - name: Install packages
+        run: npm ci
 
       - name: Run changelog-image
         run: npm run changelog-image

.github/workflows/release-build.yml

@@ -33,9 +33,11 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
+          cache: 'npm'
+          cache-dependency-path: package-lock.json
 
-      - name: Bootstrap packages
-        run: npm run bootstrap
+      - name: Install packages
+        run: npm ci
 
       - name: Package app (MacOS only)
         if: matrix.os == 'macos-latest'
@@ -60,7 +62,10 @@ jobs:
           echo "INSO_VERSION=$(jq .version packages/insomnia-inso/package.json -rj)" >> $GITHUB_ENV
 
       - name: Package inso
-        run: npm run inso-package
+        run: |
+          echo "Replacing electron binary with node binary"
+          node_modules/.bin/node-pre-gyp install --update-binary --directory node_modules/@getinsomnia/node-libcurl
+          npm run inso-package
         env:
           VERSION: ${{ env.INSO_VERSION }}
 
@@ -79,27 +84,29 @@ jobs:
 
       - name: Notarize Inso CLI installer (macOS only)
         if: matrix.os == 'macos-latest'
-        uses: devbotsxyz/xcode-notarize@v1
+        uses: lando/notarize-action@v2
         with:
           product-path: packages/insomnia-inso/artifacts/inso-${{ matrix.os }}-${{ env.INSO_VERSION }}.pkg
           primary-bundle-id: com.insomnia.inso
           appstore-connect-username: ${{ secrets.DESIGNER_APPLE_ID }}
           appstore-connect-password: ${{ secrets.DESIGNER_APPLE_ID_PASSWORD }}
+          appstore-connect-team-id: FX44YY62GV
 
       - name: Staple Inso CLI installer (macOS only)
         if: matrix.os == 'macos-latest'
-        uses: devbotsxyz/xcode-staple@v1
+        uses: BoundfoxStudios/action-xcode-staple@v1
         with:
           product-path: packages/insomnia-inso/artifacts/inso-${{ matrix.os }}-${{ env.INSO_VERSION }}.pkg
 
       - name: Notarize Inso CLI binary (macOS only)
         if: matrix.os == 'macos-latest'
-        uses: devbotsxyz/xcode-notarize@v1
+        uses: lando/notarize-action@v2
         with:
           product-path: packages/insomnia-inso/binaries/inso
           primary-bundle-id: com.insomnia.inso-binary
           appstore-connect-username: ${{ secrets.DESIGNER_APPLE_ID }}
           appstore-connect-password: ${{ secrets.DESIGNER_APPLE_ID_PASSWORD }}
+          appstore-connect-team-id: FX44YY62GV
 
       - name: Create inso artifacts
         run: npm run inso-package:artifacts
@@ -176,7 +183,7 @@ jobs:
             git merge --no-ff release/<replaced with version>
 
             # Solve merge conflicts ...
-            # If there's package-lock conflicts, run `npm run bootstrap` and commit the package-lock changes
+            # If there's package-lock conflicts, run `npm install` and commit the package-lock changes
 
             git push
             ```

.github/workflows/release-publish.yml

@@ -27,10 +27,12 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3
         with:
-          node-version-file: '.nvmrc'
+          node-version-file: ".nvmrc"
+          cache: 'npm'
+          cache-dependency-path: package-lock.json
 
-      - name: Bootstrap packages
-        run: npm run bootstrap
+      - name: Install packages
+        run: npm ci
 
       - name: Download artifact
         uses: dawidd6/action-download-artifact@v2
@@ -164,22 +166,27 @@ jobs:
           snap: artifacts/ubuntu-latest-artifacts/insomnia/dist/Insomnia.Core-${{ env.RELEASE_VERSION }}.snap
           release: ${{ contains(github.event.inputs.version, 'beta') && 'beta' || 'stable' }}
 
-      - name: Upload .deb to pulp (stable only)
-        if: ${{ env.IS_PRERELEASE == 'false' }}
+      - name: Upload .deb to pulp and/or cloudsmith (stable only)
         uses: docker://kong/release-script:latest
         env:
           PULP_USERNAME: ${{ secrets.PULP_USERNAME }}
           PULP_PASSWORD: ${{ secrets.PULP_PASSWORD }}
           PULP_HOST: ${{ secrets.PULP_HOST }}
+          VERBOSE: ${{ runner.debug == '1' && '1' || '' }}
+          CLOUDSMITH_API_KEY: ${{ secrets.CLOUDSMITH_API_KEY }}
+          CLOUDSMITH_DRY_RUN: ''
+          IGNORE_CLOUDSMITH_FAILURES: ${{ vars.IGNORE_CLOUDSMITH_FAILURES }}
+          USE_CLOUDSMITH: ${{ vars.USE_CLOUDSMITH }}
+          USE_PULP: ${{ vars.USE_PULP }}
         with:
-          entrypoint: /usr/src/code/entrypoint.sh
+          entrypoint: /entrypoint.sh
           args: >
             release
             --file artifacts/ubuntu-latest-artifacts/insomnia/dist/Insomnia.Core-${{ env.RELEASE_VERSION }}.deb
             --dist-name ubuntu
             --dist-version focal
             --package-type insomnia
-            --publish
+            ${{ env.IS_PRERELEASE == 'true' && '--internal' || '--publish' }}
 
       - name: Push Inso CLI docker image tags to Docker Hub
         run: |

.github/workflows/release-recurring.yml

@@ -18,7 +18,7 @@ env:
 jobs:
   build-and-upload-artifacts:
     # Skip jobs for release PRs
-    if: "!startsWith(github.head_ref, 'release/')"
+    if: ${{ !startsWith(github.head_ref, 'release/') }}
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -38,18 +38,32 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version-file: ".nvmrc"
+          cache: 'npm'
+          cache-dependency-path: package-lock.json
 
-      - name: Bootstrap packages
-        run: npm run bootstrap
+      - name: Install packages
+        run: npm ci
 
       - name: Bump version
         shell: bash
-        run: BUILD_REF="$(git rev-parse --short HEAD)${{ github.event_name == 'pull_request' && '.pr-$PR_NUMBER' || '' }}" npm run app-bump-version
+        run: npm --workspaces version prerelease --preid="$(git rev-parse --short HEAD)${{ github.event_name == 'pull_request' && '.pr-$PR_NUMBER' || '' }}" --no-git-tag-version
 
       - name: Package
         shell: bash
         run: NODE_OPTIONS='--max_old_space_size=6144' BUILD_TARGETS='${{ matrix.build-targets }}' npm run app-package
 
+      - name: Test critical path on packaged electron app
+        run: npm run test:package -w packages/insomnia-smoke-test -- --project=Critical
+        env:
+          INSOMNIA_UPDATES_URL: http://localhost:4010
+
+      - name: Upload smoke test traces
+        uses: actions/upload-artifact@v3
+        with:
+          if-no-files-found: ignore
+          name: ${{ matrix.os }}-package-critical-test-traces-${{ github.run_number }}
+          path: packages/insomnia-smoke-test/traces
+
       - name: Upload artifacts
         uses: actions/upload-artifact@v3
         with: