Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to each channel to enable/disable metering #151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dsheeler
Copy link
Member

This also disables processing of the metering on C side, though that's minimal in the case of non-kmetering. Closes #102.

@dsheeler dsheeler requested a review from SpotlightKid October 26, 2021 09:57
@SpotlightKid
Copy link
Contributor

I get the following error message when I open an existing mixer settings XML file:

Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'OutputChannel' object has no attribute 'vbox_meter'

@dsheeler
Copy link
Member Author

I get the following error message when I open an existing mixer settings XML file:

Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'InputChannel' object has no attribute 'vbox_meter'
Traceback (most recent call last):
  File "/home/chris/work/jack_mixer/jack_mixer/channel.py", line 342, in on_metering_toggled
    self.vbox_meter.show()
AttributeError: 'OutputChannel' object has no attribute 'vbox_meter'

@SpotlightKid: fixed it

@SpotlightKid
Copy link
Contributor

Repeating what I said on #jack_mixer:

I must say, I don't like the extra button, it takes up additional vertical space and is also rather wide, preventing the channels from being as narrow as they can, when set to narrow width.

Maybe we should think about overhauling the channel buttons layout and put them all in a grid structure, each the same size and maybe image instead of text labels.
We could then also move the prefader meter button there.

@dsheeler
Copy link
Member Author

@SpotlightKid Where would we get images for the buttons?

@synthnassizer
Copy link
Contributor

synthnassizer commented May 15, 2022 via email

@SpotlightKid
Copy link
Contributor

Where would we get images for the buttons?

I don't know, check some of the common web icon fonts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable VU meter analysis/displays?
3 participants