Dependency updates (for solving security issues) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lodash versions <=4.17.4 were vulnerable to Prototype Pollution, for details please see: https://www.npmjs.com/advisories/577 For changes in Lodash 4.x please see: https://github.com/lodash/lodash/releases/tag/4.0.0 https://github.com/lodash/lodash/wiki/Changelog#compatibility-warnings Only this change was needed to pay attention to: * Removed _.pluck in favor of _.map with iteratee shorthand Here are other changes related to methods used in font-loader but there is no need to change anything in code: * Split _.assign & _.assignIn into _.assignWith & _.assignInWith * Split _.invert into _.invertBy * Split _.omit & _.pick into _.omitBy & _.pickBy * Split _.uniq into _.sortedUniq, _.sortedUniqBy, & _.uniqBy * Made “By” methods like _.groupBy & _.sortBy provide a single param to iteratees * Removed multiValue param from _.invert * Removed legacy options param signature from _.template * Enabled shortcut fusion for _.find
According to the change logs, there are no API changes in these packages thus only package.json can be edited: https://github.com/fontello/ttf2eot/blob/master/CHANGELOG.md https://github.com/fontello/ttf2woff/blob/master/CHANGELOG.md
Though vulnerability https://nodesecurity.io/advisories/577 was fixed in Lodash 4.17.5, versions <=4.17.11 remained vulnerable to Prototype Pollution, for details please see: https://www.npmjs.com/advisories/1065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #9 for details.