This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
Tag permissions #168 reroll #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any unit test in this PR. Have considered adding some ? I'd say that security related things are quite important to be well tested. |
|
Totally agree - I do need some help as I am not accustomed to write ruby or redmine plugins. We needed this functionality so I rerolled and tested it for our application. |
|
See my latest comment in #168 It now also includes view permissions. But it's not yet tested properly. Unit tests are also missing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #168 and rebased it on current version.
Confirmed this is working as expected. Thanks to the original contributor!