Urql graphql client #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added db connection added customer table
split to load and display component
.gitignore
Outdated
| @@ -5,6 +5,9 @@ | |||
| /.pnp | |||
| .pnp.js | |||
|
|
|||
| # packages | |||
| package-lock.json | |||
There was a problem hiding this comment.
we would like to commit this file
src/index.tsx
Outdated
| case 'sk': | ||
| case 'sk-SK': | ||
| return import('./compiled-lang/sk.json'); | ||
| case "sk": |
There was a problem hiding this comment.
do not change formatting when you are adding a feature (in future there are will be merge conflicts...)
| import { CustomersTable } from "./CustomersTable"; | ||
|
|
||
| const SEARCH = gql` | ||
| query Search($search: String!) { |
There was a problem hiding this comment.
query searchCustomers
I am not sure if $search should be mandatory.
change Prettier settings (single quotes, remove semicolons) added package-lock.json
jozef-slezak
reviewed
Apr 1, 2021
package.json
Outdated
| @@ -39,6 +42,7 @@ | |||
| ] | |||
| }, | |||
| "devDependencies": { | |||
| "@types/react": "^17.0.3", | |||
There was a problem hiding this comment.
let's have the same version with react...
jozef-slezak
reviewed
Apr 1, 2021
src/index.tsx
Outdated
| import { IntlProvider } from 'react-intl' | ||
| import { BrowserRouter as Router, Switch, Route } from 'react-router-dom' | ||
| import { Dashboard, HelloWorld } from './components' | ||
| import { CustomerListView } from './views/customer/app' |
There was a problem hiding this comment.
Let's rename the file ./view/customer/app to ./view/customer/CustomerListView
jozef-slezak
reviewed
Apr 5, 2021
| header: <Text>Registration date</Text>, | ||
| primary: true, | ||
| render: (customer) => ( | ||
| <Text>{moment(customer.createdAt).format('DD/MM/YYYY')}</Text> |
There was a problem hiding this comment.
Please, format using react-intl instead moment
- change same react version - rename file customer/app to customer/CustomerListView - format using react-intl
jozef-slezak
reviewed
Apr 6, 2021
package.json
Outdated
| "grommet": "2.11.0", | ||
| "grommet-icons": "4.4.0", | ||
| "grommet-theme-v1": "^0.1.0", | ||
| "moment": "^2.27.0", |
There was a problem hiding this comment.
please remove unused dependency
Closed
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8