test_query_e2e: interrupt process only once #614
+38
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
ae02ab3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f36b37ef.datachain-documentation.pages.dev |
| Branch Preview URL: | https://interrupt-only-once.datachain-documentation.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 106 106
Lines 10286 10288 +2
Branches 1386 1386
=======================================
+ Hits 9015 9017 +2
Misses 929 929
Partials 342 342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…rrupt While running script, sending <kbd>Ctrl</kbd> + <kbd>C</kbd> would also send SIGINT to the worker processes, but then [it would immediately follow up with a SIKILL][1] [after 0.25s][2]. This allowed very little time for workers to do cleanup, due to which, Python was raising `UserWarning` for leaked semaphores due to this: ```py .../lib/python3.12/site-packages/multiprocess/resource_tracker.py:257: UserWarning: resource_tracker: There appear to be 6 leaked semaphore objects to clean up at shutdown ``` Also see python/cpython#70130. This patch changes worker processes to be run using `subprocess.Popen` rather than `subprocess.run`, so that SIGKILL never gets sent. [1]: https://github.com/python/cpython/blob/3c770e3f0978d825c5ebea98fcd654660e7e135f/Lib/subprocess.py#L571-L573 [2]: https://github.com/python/cpython/blob/3c770e3f0978d825c5ebea98fcd654660e7e135f/Lib/subprocess.py#L891
skshetry
force-pushed
the
interrupt-only-once
branch
from
1ccc4ee
to
ae02ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.