Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using job class instead of hardcodced Job #391

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

ilongin
Copy link
Contributor

@ilongin ilongin commented Sep 4, 2024

Using job_class private property instead of Job to avoid issues in SaaS where we have extended class with additional fields.

@ilongin ilongin linked an issue Sep 4, 2024 that may be closed by this pull request
Copy link

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba50c45
Status: ✅  Deploy successful!
Preview URL: https://b2b333aa.datachain-documentation.pages.dev
Branch Preview URL: https://ilongin-390-use-job-class.datachain-documentation.pages.dev

View logs

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (16ed477) to head (ba50c45).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/datachain/data_storage/metastore.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files          92       92           
  Lines       10121    10121           
  Branches     2054     2054           
=======================================
  Hits         8784     8784           
  Misses        988      988           
  Partials      349      349           
Flag Coverage Δ
datachain 86.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilongin ilongin merged commit cbd20f2 into main Sep 4, 2024
37 of 38 checks passed
@ilongin ilongin deleted the ilongin/390-use-job-class branch September 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use job class instead of hardcoded Job in AbstractDBMetastore
3 participants