query: remove support for saving dataset query with a given name #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Sep 4, 2024
| @@ -1297,19 +1297,6 @@ def create_dataset_from_sources( | |||
|
|
|||
| return self.get_dataset(name) | |||
|
|
|||
| def register_new_dataset( | |||
There was a problem hiding this comment.
This API is no longer used after removing save_as logic from query_wrapper below, so I have removed it.
skshetry
commented
Sep 4, 2024
Comment on lines
+193
to
+194
| if not save: | ||
| assert result.dataset is None | ||
| return |
There was a problem hiding this comment.
Previous test did not test with save=False and when save_as=None. So this scenario was never hit.
I am only testing this just to make parametrization easier. #360 will require adjusting these anyway.
skshetry
force-pushed
the
drop-save-as
branch
from
a84d793
to
7cd0d9a
Compare
Reverts iterative/dvcx#1443. Since we want to make save explicits via users, and are dropping last expression wrapping thing in iterative#360, we won't have any mechanism to support this feature.
skshetry
force-pushed
the
drop-save-as
branch
from
7cd0d9a
to
6fe8e24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 86.78% 86.76% -0.03%
==========================================
Files 92 92
Lines 10121 10098 -23
Branches 2054 2050 -4
==========================================
- Hits 8784 8762 -22
+ Misses 988 987 -1
Partials 349 349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dreadatour
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts https://github.com/iterative/dvcx/pull/1443.
Since we want to make
saveexplicits via users, and are dropping last expression wrapping thing in #360, we won't have any mechanism to support this feature.Also, this feature is only used in CLI which is no longer exposed to the users.
Part of #360.