Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix v0.14 #1467

Merged
merged 5 commits into from
May 16, 2023
Merged

Hotfix v0.14 #1467

merged 5 commits into from
May 16, 2023

Conversation

Alan-Cha
Copy link
Member

Related to #1458

@Alan-Cha
Copy link
Member Author

I did not change the version in the testdata files. I'm not sure if I should but I tested one or two, and they still work with v0.13.

@Alan-Cha
Copy link
Member Author

Alan-Cha commented May 15, 2023 •
edited
Loading

  • Additional Helm chart linting / ...: failing due to preexisting issue grpc task file system vulnerability #1460 (4 failed tests)
  • Test experiment charts using testdata charts / unit-test: failing due to 0.14 not being in iter8 chart hub (should be resolved after this PR) (1 failed test)
  • Test experiment charts using local charts / ...: failing due to no 0.14 Docker image (should be resolved after making a release after this PR) (8 failed tests)
  • Test kustomize experiments / ...: failing due to no 0.14 Docker image (should be resolved after making a release after this PR) (4 failed tests)

Total 17 failed checks

sriumcp
sriumcp requested changes May 15, 2023
View reviewed changes
Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested.

Dockerfile.dev Outdated Show resolved Hide resolved
@Alan-Cha
Remove Dockerfile.dev
205dd01 
Signed-off-by: Alan Cha <[email protected]>
@sriumcp sriumcp self-requested a review May 15, 2023 21:17
sriumcp
sriumcp approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alan-Cha
Copy link
Member Author

Fewer failing tests, 15, than before, 17, but that seems to be because failed tests prematurely stop the workflow and the number of failed tests is non-deterministic. Test kustomize experiments has fewer failed tests this time. Everything still seems fine. Feel free to merge.

@sriumcp sriumcp merged commit 8f80f45 into iter8-tools:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriumcp sriumcp sriumcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alan-Cha @sriumcp