Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge hub repo into iter8 repo #1459

Merged
merged 13 commits into from
May 11, 2023
Merged

Merge hub repo into iter8 repo #1459

merged 13 commits into from
May 11, 2023

Conversation

Alan-Cha
Copy link
Member

Fix #1457

Alan-Cha added 11 commits May 10, 2023 09:09
@Alan-Cha
Move files
8735c2c 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Add release charts workflow
2442b88 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Change to alan-cha.github.io
1d3e250 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Point workflow to master
274e7cd 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Add hub workflows
b1f468c 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Revert back to iter8-tools.github.io
87a4ba9 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Remove iter8 from gitignore
ea230ca 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Fix spacing
8d2d7e6 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Renaming
7f58eec 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Fix version bump workflow
43f340a 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Adjustment
19095de 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Copy link
Member Author

The Additional Helm chart linting workflow should fail because of #1460

@Alan-Cha
Copy link
Member Author

Tests / unit-test workflow should fail because the failing test TestKubeLaunch tries to reach the Helm chart in the iter8 repo, which will be created upon accepting this PR

looks like "https://iter8-tools.github.io/iter8" is not a valid chart repository or cannot be reached

Alan-Cha added 2 commits May 10, 2023 16:31
@Alan-Cha
Remove space
b742356 
Signed-off-by: Alan Cha <[email protected]>
@Alan-Cha
Rename tests
ed230f4 
Signed-off-by: Alan Cha <[email protected]>
@sriumcp sriumcp self-requested a review May 11, 2023 02:52
sriumcp
sriumcp requested changes May 11, 2023
View reviewed changes
.github/workflows/release-drafter.yaml
@@ -1,17 +0,0 @@
name: Release Drafter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be removed. It has to do with the release of the Iter8 CLI as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sriumcp I did not remove this file, I just renamed it. See here

I just thought the name was ugly because none of the other workflows have a hyphen in their names

@Alan-Cha Alan-Cha marked this pull request as ready for review May 11, 2023 14:07
@sriumcp sriumcp self-requested a review May 11, 2023 14:09
sriumcp
sriumcp approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@sriumcp sriumcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sriumcp sriumcp merged commit 0417e5d into iter8-tools:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriumcp sriumcp sriumcp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge hub repo into iter8 repo
2 participants
@Alan-Cha @sriumcp