Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News page #153

Merged
merged 40 commits into from
Oct 26, 2023
Merged

News page #153

merged 40 commits into from
Oct 26, 2023

Conversation

Ngaremaina
Copy link
Contributor

@Ngaremaina Ngaremaina commented Oct 3, 2023

Description

Adding the news page and styling the news page

Issue #7 .

Fixes #7

Tags
@danielsdgg @afrikhana

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshot (optional)

Screenshot from 2023-10-04 15-10-29
Screenshot from 2023-10-04 15-10-18
Screenshot from 2023-10-04 15-10-07

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • The page runs on the browser
  • The page displays the components as expected

Test Configuration: (optional)

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Ngaremaina and others added 23 commits September 28, 2023 12:51
Copy link
Collaborator

@JAPHETHNYARANGA JAPHETHNYARANGA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the text sizes and their weights, the horizontal line is not end to end as per the design, and how did the screen shot work with the styles attached only.Screen shot looks good but i cant see the styles.Please check on this. Thanks.

@JAPHETHNYARANGA
Copy link
Collaborator

THis is good work, but always remember to just push the required files. For the specific issue

@JAPHETHNYARANGA JAPHETHNYARANGA merged commit bcfea1e into italanta:main Oct 26, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎨 Create Home Page News Section Component
2 participants