Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 create the home landing page #2 #108

Merged

Conversation

Schola-droid
Copy link
Contributor

@Schola-droid Schola-droid commented Sep 30, 2023

Description

A navigation bar with links and a contact button.
Content includes a heading, a paragraph, and a button with an arrow icon.
An image with the class "feature-image
Responsiveness in desktop, tablet, and mobile devices.

Fixes # (#40 )

Screenshot (optional)

Desktop:
Screenshot 2023-10-09 at 00 42 53

Tablet:
Screenshot 2023-10-09 at 00 48 51

Mobile:
Screenshot 2023-10-09 at 00 49 51

Did it with https://github.com/paul-nadola

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Collaborator

@JAPHETHNYARANGA JAPHETHNYARANGA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the page responsive, i cannot see specific screen sizes specified. https://www.w3schools.com/css/css_rwd_mediaqueries.asp

Comment on lines 21 to 22
margin-top: 0px;
margin-left: 200px
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single margin property here
If the margin property has four values:

margin: 25px 50px 75px 100px;
top margin is 25px
right margin is 50px
bottom margin is 75px
left margin is 100px

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single margin property here If the margin property has four values:

margin: 25px 50px 75px 100px; top margin is 25px right margin is 50px bottom margin is 75px left margin is 100px

Okay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the revision @JAPHETHNYARANGA

src/ts/index.ts Outdated
Comment on lines 1 to 2
const b = "elewa"
console.log(b);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary for the pull request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary for the pull request

Noted sir.

@Schola-droid
Copy link
Contributor Author

Is the page responsive, i cannot see specific screen sizes specified. https://www.w3schools.com/css/css_rwd_mediaqueries.asp

Working on it sir

@JAPHETHNYARANGA JAPHETHNYARANGA merged commit c006ff6 into italanta:main Oct 11, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants