Develop into calculators constructor base branch #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix scroll bug * make scrolling smooth
Created show page for calculators
* closes #931-fix-selflock-bug * added validation in controller and test * added request test * before_action added * Update app/controllers/account/users_controller.rb Co-authored-by: Ivan Marynych <[email protected]> * guard style return * Update app/controllers/account/users_controller.rb Co-authored-by: Ivan Marynych <[email protected]> * Update users_controller.rb * dig * Update users_controller.rb * Update users_controller.rb * Update users_controller.rb --------- Co-authored-by: Ivan Marynych <[email protected]>
…n-products Restrict input to two decimal places in price input fields
* Created menstrual hygiene calculator. Created corresponding to it view, api controller, service and validator. Also added new corresponding action to render mhc calculator to calculators controller. * Fixed link and rubocop offences * Updated rubocop target version and extracted methods in pad usage service * Deleted redundant skip * Added tests for api controller * Fixed some files * Removed redundant code from controllers action * Added smooth scroll * Fixed localization with links * Fixed rubocops target version * Fixed typo * Fixed CI * Refactored code for a better style * Added tests for validator * Fixed offenses * Added tests for each of the validate param method * Retrieved shared example to separate file * Added before hook for blank param --------- Co-authored-by: Ivan Marynych <[email protected]> Co-authored-by: loqimean <[email protected]>
Auto deploy to staging by GitHub action and Capistrano
Add key for autodeploy to staging
…gory #866-fix refreshing new Category page
Fix key reference
Update README.md
* Added flipper, so admin could enable or disable mhc calculator
920 Added seeds for categories
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #985 +/- ##
===========================================================
+ Coverage 83.98% 85.12% +1.14%
===========================================================
Files 65 68 +3
Lines 974 1049 +75
===========================================================
+ Hits 818 893 +75
Misses 156 156 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
Summary of issue
There is no latest changes in the constructors base branch from develop branch
Summary of change
Merge changes from develop to base constructors branch
CHECK LIST