Textarea for formula #973
Merged
Textarea for formula #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #973 +/- ##
========================================================
Coverage 86.74% 86.74%
========================================================
Files 68 68
Lines 1056 1056
========================================================
Hits 916 916
Misses 140 140 ☔ View full report in Codecov by Sentry. |
NVMakarenko
approved these changes
Nov 25, 2024
loqimean
requested changes
Nov 25, 2024
Comment on lines
1
to
9
| document.addEventListener('input', function (event) { | ||
| if (event.target && event.target.classList.contains('resize-auto') && event.target.tagName === 'TEXTAREA') { | ||
| const textarea = event.target; | ||
| textarea.style.overflow = 'hidden'; | ||
| textarea.style.resize = 'none'; | ||
| textarea.style.height = 'auto'; | ||
| textarea.style.height = (textarea.scrollHeight) + 'px'; | ||
| } | ||
| }); |
There was a problem hiding this comment.
юзай для цього стімулус контроллер
app/javascript/application.js
Outdated
| @@ -7,4 +7,5 @@ import "@fortawesome/fontawesome-free"; | |||
| import "@rails/request.js"; | |||
| import "@rails/actioncable"; | |||
| import "turbo_streams/toast"; | |||
| import "@oddcamp/cocoon-vanilla-js" | |||
| import "@oddcamp/cocoon-vanilla-js"; | |||
| import "resize_textarea"; | |||
There was a problem hiding this comment.
тобі на всіх пейджах потрібен цей скріпт?
loqimean
approved these changes
Nov 26, 2024
app/javascript/application.js
Outdated
| @@ -7,4 +7,4 @@ import "@fortawesome/fontawesome-free"; | |||
| import "@rails/request.js"; | |||
| import "@rails/actioncable"; | |||
| import "turbo_streams/toast"; | |||
| import "@oddcamp/cocoon-vanilla-js" | |||
| import "@oddcamp/cocoon-vanilla-js" | |||
There was a problem hiding this comment.
Нема строки в кінці файлу
Comment on lines
1
to
9
| document.addEventListener('input', function (event) { | ||
| if (event.target && event.target.classList.contains('resize-auto') && event.target.tagName === 'TEXTAREA') { | ||
| const textarea = event.target; | ||
| textarea.style.overflow = 'hidden'; | ||
| textarea.style.resize = 'none'; | ||
| textarea.style.height = 'auto'; | ||
| textarea.style.height = (textarea.scrollHeight) + 'px'; | ||
| } | ||
| }); |
Comment on lines
1
to
9
| document.addEventListener('input', function (event) { | ||
| if (event.target && event.target.classList.contains('resize-auto') && event.target.tagName === 'TEXTAREA') { | ||
| const textarea = event.target; | ||
| textarea.style.overflow = 'hidden'; | ||
| textarea.style.resize = 'none'; | ||
| textarea.style.height = 'auto'; | ||
| textarea.style.height = (textarea.scrollHeight) + 'px'; | ||
| } | ||
| }); |
loqimean
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
Second Level Review
Summary of issue
Add textarea field for formula
Summary of change
textarea added and script to autoresize it
ZeroWaste.-.Google.Chrome.2024-11-26.21-58-53.mp4
Testing approach
test pass locally
CHECK LIST