Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badges #967

Merged
merged 16 commits into from
Nov 29, 2024
Merged

Add badges #967

merged 16 commits into from
Nov 29, 2024

Conversation

AndriiKhomik
Copy link
Collaborator

dev

JIRA

Code reviewers

Second Level Review

  • @github_username

Summary of issue

Add badges of pipeline result

Summary of change

Split workflow files to be able display workflow result in a different budges

Testing approach

Trigger pipeline

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (f73b6d8) to head (d187767).
Report is 48 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #967   +/-   ##
========================================
  Coverage    91.76%   91.76%           
========================================
  Files           73       73           
  Lines         1044     1044           
========================================
  Hits           958      958           
  Misses          86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated
@@ -185,3 +185,5 @@ Run `git commit -m "name"` to commit changes locally.
If you have some troubles with style conventions after running `git commit -m "name"`, you need to run `rubocop -a` or `rubocop -A`. Each of these commands can resolve the majority of warnings.

Type `git commit -m "name" --no-verify` for commiting without formating.

[![CI](https://github.com/ita-social-projects/ZeroWaste/actions/workflows/ci.yml/badge.svg)](https://github.com/ita-social-projects/ZeroWaste/actions/workflows/ci.yml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

баджі повинні бути зверху, також додай бадж на CD

@loqimean loqimean merged commit ed46e91 into develop Nov 29, 2024
5 checks passed
@loqimean loqimean deleted the add-badges branch November 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants