fix 'Calculator' page reverting after changing locale #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loqimean
requested changes
Nov 5, 2024
| @@ -1,5 +1,6 @@ | |||
| <div class="container"> | |||
| <%= simple_form_for @calculator, url: account_calculators_path do |f| %> | |||
| <%= hidden_field_tag :rendered_from, "new" %> | |||
There was a problem hiding this comment.
не гуд, таких форм у тебе рахуй 10 і на кожну потрібна перевірка?) не гуд, шукай інший солюшен, більш лайтовий
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #928 +/- ##
========================================
Coverage 91.16% 91.16%
========================================
Files 70 70
Lines 973 973
========================================
Hits 887 887
Misses 86 86 ☔ View full report in Codecov by Sentry. |
NVMakarenko
requested review from
loqimean,
igorSimash,
DanielVajnagi,
ktpe,
alexy78,
olexandervanzuriak,
SleekMutt and
KseniaGovorun
KseniaGovorun
approved these changes
Nov 7, 2024
NVMakarenko
removed request for
olexandervanzuriak,
igorSimash,
DanielVajnagi,
SleekMutt,
alexy78 and
ktpe
KseniaGovorun
approved these changes
Nov 8, 2024
loqimean
requested changes
Nov 8, 2024
| @@ -0,0 +1 @@ | |||
| <div data-controller="redirect" data-url="<%= account_calculators_path %>"></div> | |||
There was a problem hiding this comment.
turbo_stream.append :body_js do
<script>
window.location.replace("<%= account_calculators_path %>")
</script>
end| @@ -0,0 +1 @@ | |||
| <%= turbo_stream.replace(dom_id(@calculator, :form), partial: "account/calculators/partials/new/form", locals: {calculator: @calculator}) %> | |||
There was a problem hiding this comment.
Suggested change
| <%= turbo_stream.replace(dom_id(@calculator, :form), partial: "account/calculators/partials/new/form", locals: {calculator: @calculator}) %> | |
| <%= turbo_stream.replace(dom_id(@calculator, :form), partial: "account/calculators/partials/new/form", locals: { calculator: @calculator }) %> | |
loqimean
approved these changes
Nov 19, 2024
loqimean
force-pushed
the
develop
branch
4 times, most recently
from
03a3caf to
7d2dc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
PROJECT
Board ticket
Code reviewers
Summary of issue
New calculator is not creating because of validation failed. Error message is shown. If change locale on this stage, admin will be redirected to Calculator's page.
Expected result
'New calculator' page is reload and displayed.
'Name' field is blank.
Error message is absent.
Summary of change
fix.reverting.mp4
CHECK LIST