Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formula relations to calculators constructor #1006

Open
wants to merge 8 commits into
base: calculators-constructor
Choose a base branch
from

Conversation

olexandervanzuriak
Copy link
Contributor

@olexandervanzuriak olexandervanzuriak commented Dec 11, 2024

#989

Code reviewers

Summary of issue

Add relation to calculators constructor so that they looks similar to dippers calculator relations

image

Result

Added select input field on creating calculator constructor

Video.mp4

Results on show page

Video2.mp4

Summary of change

Added relation field to formula model and validations for it

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • PR meets all conventions

Sorry, something went wrong.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (1df17d5) to head (d2ebd53).
Report is 5 commits behind head on calculators-constructor.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           calculators-constructor    #1006      +/-   ##
===========================================================
+ Coverage                    87.07%   87.29%   +0.21%     
===========================================================
  Files                           68       69       +1     
  Lines                         1060     1078      +18     
===========================================================
+ Hits                           923      941      +18     
  Misses                         137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexandervanzuriak olexandervanzuriak linked an issue Dec 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Create result's relations
1 participant