Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created edit functionality #1002

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

ktpe
Copy link
Contributor

@ktpe ktpe commented Dec 3, 2024

Code reviewers

Second Level Review

Summary of issue

There is no update functionality for calculators

Summary of change

Created update functionality for calculators

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (1df17d5) to head (7858938).
Report is 5 commits behind head on calculators-constructor.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           calculators-constructor    #1002      +/-   ##
===========================================================
+ Coverage                    87.07%   89.10%   +2.03%     
===========================================================
  Files                           68       68              
  Lines                         1060     1056       -4     
===========================================================
+ Hits                           923      941      +18     
+ Misses                         137      115      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SleekMutt SleekMutt added the enhancement New feature or request label Dec 3, 2024
Copy link
Collaborator

@loqimean loqimean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but where are specs

Copy link
Collaborator

@loqimean loqimean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writespecs please, or check its availability and consistency

@SleekMutt SleekMutt self-assigned this Dec 6, 2024
@SleekMutt SleekMutt requested a review from loqimean December 8, 2024 11:01
@SleekMutt SleekMutt merged commit cdf3740 into calculators-constructor Dec 13, 2024
7 checks passed
@SleekMutt SleekMutt deleted the edit_calculator branch December 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for QA
Development

Successfully merging this pull request may close these issues.

3 participants