Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show page #1001

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

DanielVajnagi
Copy link
Contributor

@DanielVajnagi DanielVajnagi commented Dec 2, 2024

Code reviewers

Second Level Review

Summary of issue

Add showpage for calculator on admin side

Summary of change

added showpage

image

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@DanielVajnagi DanielVajnagi self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (a316685) to head (283ae98).
Report is 1 commits behind head on calculators-constructor.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           calculators-constructor    #1001      +/-   ##
===========================================================
+ Coverage                    87.05%   87.06%   +0.01%     
===========================================================
  Files                           68       68              
  Lines                         1058     1059       +1     
===========================================================
+ Hits                           921      922       +1     
  Misses                         137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@loqimean loqimean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solve conflicts please

@DanielVajnagi DanielVajnagi merged commit 468f543 into calculators-constructor Dec 4, 2024
7 checks passed
@DanielVajnagi DanielVajnagi deleted the admin-showpage-calculators branch December 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for QA
Development

Successfully merging this pull request may close these issues.

3 participants