Registration on challenge #1696
Conversation
AVykhovanok
changed the title
|
Improve your code: |
src/main/java/com/softserve/teachua/controller/UserChallengeController.java
Outdated
Show resolved
Hide resolved
| @PostMapping("/admin/user-challenge/challenge/duration/registered-users") | ||
| public List<UserChallengeForAdminRegisteredUser> getListRegisteredUsersByChallengeIdChallengeDurationId( | ||
| @RequestBody UserChallengeForAdminGetByChallengeIdDurationId userChallenge) { | ||
| return userChallengeService.getListRegisteredUsersByChallengeIdChallengeDurationId(userChallenge); |
There was a problem hiding this comment.
Add JavaDoc to explain what this method do and try to avoid naming like this getListRegisteredUsersByChallengeIdChallengeDurationId
| false, | ||
| challenge, | ||
| durationEntity))); | ||
| return "Успішно"; |
There was a problem hiding this comment.
Add more information at the response. Better create response message in corresponding controller.
| @Transactional | ||
| public class DurationEntityServiceImpl implements DurationEntityService { | ||
| private final DurationEntityRepository durationEntityRepository; | ||
| private final DtoConverter dtoConverter; |
There was a problem hiding this comment.
Remove this unused "dtoConverter" private field
| return durationEntityRepository.findAll(); | ||
| } | ||
|
|
||
| public Set<DurationEntity> mapDurationResponseListToDurationEntity( |
There was a problem hiding this comment.
From my point of view, the method should be private because it used only in this class.
| .orElseThrow(() -> new NotExistException( | ||
| String.format(USER_CHALLENGE_STATUS_NOT_FOUND_BY_STATUS_NAME, statusName))), | ||
| UserChallengeStatusGet.class); | ||
| log.debug("**/getting UserChallengeStatusGet by statusName = " + statusName); |
There was a problem hiding this comment.
Instead of + for concatenation string in log messages, use {}
| } | ||
| UserChallengeStatus userChallengeStatus = userChallengeStatusRepository.save( | ||
| dtoConverter.convertToEntity(userChallengeStatusAdd, new UserChallengeStatus())); | ||
| log.debug("**/adding new userChallengeStatus = " + userChallengeStatusAdd.getStatusName()); |
There was a problem hiding this comment.
Instead of + for concatenation string in log messages, use {}
| public UserChallengeStatusUpdate updateUserChallengeStatus(UserChallengeStatusUpdate userChallengeStatusUpdate) { | ||
| UserChallengeStatus newUserChallengeStatus = getUserChallengeStatusById(userChallengeStatusUpdate.getId()); | ||
| newUserChallengeStatus.setStatusName(userChallengeStatusUpdate.getStatusName()); | ||
| log.debug("**/updating UserChallengeStatus by userChallengeStatusUpdate = " + newUserChallengeStatus); |
There was a problem hiding this comment.
Instead of + for concatenation string in log messages, use {}
| UserChallengeStatus userChallengeStatus = userChallengeStatusRepository | ||
| .getUserChallengeStatusById(id) | ||
| .orElseThrow(() -> new NotExistException(String.format(USER_CHALLENGE_STATUS_NOT_FOUND_BY_ID, id))); | ||
| log.debug("**/getting UserChallengeStatus by id = " + id); |
There was a problem hiding this comment.
Instead of + for concatenation string in log messages, use {}
| UserChallengeStatus userChallengeStatus = getUserChallengeStatusById(id); | ||
| try { | ||
| userChallengeStatusRepository.deleteById(id); | ||
| userChallengeStatusRepository.flush(); |
There was a problem hiding this comment.
I guess, userChallengeStatusRepository.flush(); is redundant here.
|
SonarCloud Quality Gate failed. |
Pull Request template
Please, go through these steps before you submit a PR.
Make sure that your PR fulfills these requirements:
a. You have done your changes in a separate branch. Branches MUST have descriptive names.
b. You have a descriptive commit message with a short title (first line).
c. You have only one commit (if not, squash them into one commit).
d.
mvn verifydoesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).After these steps, you're ready to open a pull request.
a. Your pull request MUST NOT target the
mainbranch on this repository. You probably want to targetrestinstead.b. Give a descriptive title to your PR.
c. Provide a description of your changes.
d. Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING
Checklist:
>=75%