Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added limit for news text #939

Merged
merged 1 commit into from
Oct 30, 2023
Merged

added limit for news text #939

merged 1 commit into from
Oct 30, 2023

Conversation

FlSlaves
Copy link
Contributor

@FlSlaves FlSlaves commented Oct 20, 2023 •
edited
Loading

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

Issue

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@FlSlaves FlSlaves added the enhancement New feature or request label Oct 20, 2023
@FlSlaves FlSlaves requested review from a team October 20, 2023 10:07
@FlSlaves FlSlaves self-assigned this Oct 20, 2023
@FlSlaves FlSlaves changed the base branch from master to develop October 20, 2023 10:07
KateYatsiuk
KateYatsiuk reviewed Oct 21, 2023
View reviewed changes
Copy link
Contributor

@KateYatsiuk KateYatsiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket or any description???

@FlSlaves FlSlaves requested a review from KateYatsiuk October 21, 2023 09:33
@MementoMorj MementoMorj merged commit 13a8024 into develop Oct 30, 2023
1 check passed
@IvannYad IvannYad deleted the news-text-limit-add branch March 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MementoMorj MementoMorj MementoMorj approved these changes

@AndriiS1 AndriiS1 AndriiS1 approved these changes

@KateYatsiuk KateYatsiuk Awaiting requested review from KateYatsiuk

Assignees

@FlSlaves FlSlaves

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlSlaves @AndriiS1 @MementoMorj @KateYatsiuk